From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cody Doucette Subject: Re: [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header() Date: Sun, 28 Oct 2018 16:54:58 -0400 Message-ID: References: <20180727135243.147744-1-doucette@bu.edu> <1549031.gagrcBMtR4@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: dev@dpdk.org, Gaetan Rivet , "Ananyev, Konstantin" , Olivier Matz , "Dumitrescu, Cristian" , Michel Machado , "Fu, Qiaobin" To: thomas@monjalon.net Return-path: Received: from relay55.bu.edu (relay55.bu.edu [128.197.228.15]) by dpdk.org (Postfix) with ESMTP id D972B5920 for ; Sun, 28 Oct 2018 21:55:34 +0100 (CET) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay55.bu.edu (8.14.3/8.14.3) with ESMTP id w9SKtCrr009858 for ; Sun, 28 Oct 2018 16:55:12 -0400 Received: by mail-ed1-f72.google.com with SMTP id x44-v6so4353985edd.17 for ; Sun, 28 Oct 2018 13:55:12 -0700 (PDT) In-Reply-To: <1549031.gagrcBMtR4@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Garbage in what sense? I would be happy to amend with a little more information. The changes to failsafe and rte_net were from previous reviews from Konstantin: https://mails.dpdk.org/archives/dev/2018-June/106023.html https://mails.dpdk.org/archives/dev/2018-July/108701.html Best, Cody On Sun, Oct 28, 2018 at 6:22 AM Thomas Monjalon wrote: > 27/07/2018 15:52, Cody Doucette: > > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any > > other IPv6 extension headers when finding the fragment header. > > > > According to RFC 8200, there is no guarantee that the IPv6 > > Fragment extension header will come before any other extension > > header, even though it is recommended. > > > > Signed-off-by: Cody Doucette > > Signed-off-by: Qiaobin Fu > > Reviewed-by: Michel Machado > > --- > > v3: > > * Removed compilation flag D_XOPEN_SOURCE=700 from the > > failsafe driver to allow compilation on freebsd. > > How failsafe is related to ip_frag? > > > > v2: > > * Moved IPv6 extension header definitions to lib_net. > > > > drivers/net/failsafe/Makefile | 1 - > > drivers/net/failsafe/meson.build | 1 - > > examples/ip_reassembly/main.c | 6 ++-- > > lib/librte_ip_frag/rte_ip_frag.h | 23 ++++++------- > > lib/librte_ip_frag/rte_ip_frag_version.map | 1 + > > lib/librte_ip_frag/rte_ipv6_fragmentation.c | 38 +++++++++++++++++++++ > > lib/librte_ip_frag/rte_ipv6_reassembly.c | 4 +-- > > lib/librte_net/rte_ip.h | 27 +++++++++++++++ > > lib/librte_port/rte_port_ras.c | 6 ++-- > > Changes in failsafe, rte_net and rte_port look like garbage. > > Anyway, the ip_frag part requires some review. > +Cc Konstantin, the maintainer. > > > >