From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jyotiswarup Raiturkar <jyotisr5-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Subject: couple of minor compilation errors in DPDK 1.6
	(/lib/librte_eal/linuxapp/eal/eal_ivshmem.c)
Date: Tue, 4 Feb 2014 09:02:39 +0530
Message-ID: <CAJn5u1=yv2izSpVJXKR7HyXHbtNOmqMSey6cEkWGQLAaBfEd_A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Cc: Jyotiswarup Raiturkar <jyoti-kcDrbOQDZCdv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
To: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi

I downloaded DPDK 1.6 from the Intel website and ran into couple of
compilation errors with /lib/librte_eal/linuxapp/eal/eal_ivshmem.c. The
following changes seem to fix it.  Have other people seen these?

Thanks
Jyoti


@@ -472,7 +472,7 @@
  rte_snprintf(path, sizeof(path), IVSHMEM_CONFIG_PATH,
  internal_config.hugefile_prefix);

- fd = open(path, O_CREAT | O_RDWR);
+ fd = open(path, O_CREAT | O_RDWR, S_IRWXU | S_IRWXG | S_IRWXO );

  if (fd < 0) {
  RTE_LOG(ERR, EAL, "Could not open %s: %s\n", path, strerror(errno));
@@ -486,7 +486,8 @@
  return -1;
  }

- ftruncate(fd, sizeof(struct ivshmem_shared_config));
+ if (ftruncate(fd, sizeof(struct ivshmem_shared_config))) {
+                close(fd); return -1;
+      }

  ivshmem_config = mmap(NULL, sizeof(struct ivshmem_shared_config),
  PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);