From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rami Rosen <roszenrami@gmail.com>
Subject: Re: [dpdk-stable] [PATCH] devbind: check for lspci
Date: Sat, 10 Nov 2018 13:03:29 +0200
Message-ID: <CAKoUAr=EkD34X4jXRTp=bMBkCvp79GaqtpEr9VLRfg7ztQ3pqw@mail.gmail.com>
References: <d2749a0c9f18188c56e02e61c602e65ca88e099d.1541598755.git.anatoly.burakov@intel.com>
 <e6f3dbb8-8cea-515e-e872-50be49edd3d0@intel.com>
 <b544afca-9f01-331c-d8a6-9b85e2c1a8bd@intel.com>
 <CAKoUArmSpd7wz6d-ho-dcbWPpSnW01-Nd_wX8x_y_Jy_Lp5_xw@mail.gmail.com>
 <9e7f9bd5-b71b-4758-133e-16b1c8e6abbe@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,
 john.mcnamara@intel.com, stable@dpdk.org
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <9e7f9bd5-b71b-4758-133e-16b1c8e6abbe@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

HI Anatoly,

>Do all other distros have lspci in package called pciutils? If not, i
>prefer to keep it the way it is.

Your original patch have:

+        if ret != 0:
+            print("'lspci' not found - please install 'lspci'")

And I suggest to consider changing it to:

 >> + if ret != 0:
 >> +            print("'lspci' not found - please install pciutils')
>

Sorry about my ignorance: which distro has a package named "lspci", if at all?

The official project that include the lspci utility is called
"pciutils": see: http://mj.ucw.cz/sw/pciutils/
You can see that a package named "pciutils" is available in great many
distros, like:
Fedora, OpenSuSE, CentOS, RHEL, Ubuntu, Debian, Mandriva and Mageia,
according to the following links:

http://www.rpmfind.net/linux/rpm2html/search.php?query=pciutils&submit=Search+...
https://packages.ubuntu.com/trusty/pciutils
https://packages.debian.org/search?keywords=pciutils
https://rpms.remirepo.net/rpmphp/zoom.php?rpm=pciutils

Regards,
Rami Rosen