From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rami Rosen <roszenrami@gmail.com>
Subject: Re: [PATCH v1 2/2] examples/vdpa: add a new sample for
	vdpa
Date: Thu, 6 Sep 2018 20:24:25 +0300
Message-ID: <CAKoUArkWvSWJVoRSFTLs6gVT+wcQ7R=Lx9utX-i2ht=Y9JWtfg@mail.gmail.com>
References: <20180906131653.10752-1-xiaolong.ye@intel.com>
 <20180906131653.10752-2-xiaolong.ye@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com,
 zhihong.wang@intel.com, xiao.w.wang@intel.com
To: xiaolong.ye@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-oi0-f68.google.com (mail-oi0-f68.google.com
 [209.85.218.68]) by dpdk.org (Postfix) with ESMTP id 1ACCD4C88
 for <dev@dpdk.org>; Thu,  6 Sep 2018 19:24:37 +0200 (CEST)
Received: by mail-oi0-f68.google.com with SMTP id r69-v6so22050270oie.3
 for <dev@dpdk.org>; Thu, 06 Sep 2018 10:24:37 -0700 (PDT)
In-Reply-To: <20180906131653.10752-2-xiaolong.ye@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi all,
First, thanks for the vdpa example patches.
Second, I am getting a compilation error under Ubuntu 18.04, with gcc
version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)
...
  CC main.o
/work/src/dpdk/examples/vdpa/main.c: In function =E2=80=98main=E2=80=99:
/work/src/dpdk/examples/vdpa/main.c:321:5: error: ignoring return
value of =E2=80=98scanf=E2=80=99, declared with attribute warn_unused_resul=
t
[-Werror=3Dunused-result]
     scanf("%c", &ch);
     ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
/work/src/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target
'main.o' failed
make[1]: *** [main.o] Error 1

Also, it would be nice to have as part of this patch series adding the
relevant info in
MAINTAINERS, doc/guides/sample_app_ug/index.rst , examples/Makefile
and adding a doc/guides/sample_app_ug/vdpa.rst, like most  patches for
examples do.
See for example,

commit f5188211c721688bf8530d1648d623205246e1da
Author: Fan Zhang <roy.fan.zhang@intel.com>
Date:   Thu Apr 5 17:01:36 2018 +0100
    examples/vhost_crypto: add sample application

Regards,
Rami Rosen