From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnon Warshavsky <arnon@qwilt.com>
Subject: Re: [PATCH v12] devtools: alert on new instances of
 rte_panic and rte_exit
Date: Thu, 26 Jul 2018 23:57:39 +0300
Message-ID: <CAKy9EB1AO+vDXmOqM+5fb-JXptyC4fDEBrXRuA3FqFOw75S-Rw@mail.gmail.com>
References: <1531741077-5513-1-git-send-email-arnon@qwilt.com>
 <1531745044-19185-1-git-send-email-arnon@qwilt.com> <5378502.1ef9rKBE6e@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Doherty,
 Declan" <declan.doherty@intel.com>,
 jerin.jacob@caviumnetworks.com, Bruce Richardson <bruce.richardson@intel.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com
 [209.85.167.46]) by dpdk.org (Postfix) with ESMTP id 31CA8288C
 for <dev@dpdk.org>; Thu, 26 Jul 2018 22:57:40 +0200 (CEST)
Received: by mail-lf1-f46.google.com with SMTP id j143-v6so2118326lfj.12
 for <dev@dpdk.org>; Thu, 26 Jul 2018 13:57:40 -0700 (PDT)
In-Reply-To: <5378502.1ef9rKBE6e@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > +check_forbidden_additions() { # <file>
>
> This function looks to work with stdin, not a file.
> Better to remove the comment about a <file>.
>

It can actually work with both  but you are right. The comment is not
beneficial there
Will fix with the rest of the list below
...

>
> > +     if [ $? -ne 0 ] ; then
> > +             ret=1
> > +     fi
> > +     printf '%s\n' "$report"
>
> You are printing the report, no matter of the result? Why?
> Is it because a warning does not return as an error?
>
There is maybe an improvement required here.
>

Yes this is indeed the reason.
Sticking to a simple success/fail in the return value with the price of
printing an empty string in the case of no-warning seemed better than
handling multiple (>2) return codes .
Do you have a preferred way here?