From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnon Warshavsky Subject: Re: [PATCH] eal: register rte_panic user callback Date: Wed, 7 Mar 2018 15:23:34 +0200 Message-ID: References: <1520360928-9375-1-git-send-email-arnon@qwilt.com> <304114136.g7uiPYdxRp@xps> <4197355.YAsZy1EAlL@xps> <81ecbc4a-0200-3b42-8da1-fe87e8c14c04@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Thomas Monjalon , Bruce Richardson , dev@dpdk.org To: "Burakov, Anatoly" Return-path: Received: from mail-it0-f49.google.com (mail-it0-f49.google.com [209.85.214.49]) by dpdk.org (Postfix) with ESMTP id F22A44CA1 for ; Wed, 7 Mar 2018 14:23:35 +0100 (CET) Received: by mail-it0-f49.google.com with SMTP id d13so3272820itf.0 for ; Wed, 07 Mar 2018 05:23:35 -0800 (PST) In-Reply-To: <81ecbc4a-0200-3b42-8da1-fe87e8c14c04@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Can we add a compile warning for adding new rte_panic's into code? It's a > nice tool while debugging, but it probably shouldn't be in any new > production code. > I thought about renaming the current function and calls to something like deprecated_rte_panic() , and keep the old API with __rte_deprecated. Is this kind of API break acceptable?