From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnon Warshavsky Subject: Re: [PATCH v9 00/10] eal: replace calls to rte_panic and refrain from new instances Date: Fri, 27 Apr 2018 16:31:47 +0000 Message-ID: References: <1524663944-30376-11-git-send-email-arnon@qwilt.com> <1524723664-30510-1-git-send-email-arnon@qwilt.com> <2992884.f5kbt66Nfe@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: anatoly.burakov@intel.com, bruce.richardson@intel.com, declan.doherty@intel.com, dev@dpdk.org, ferruh.yigit@intel.com, jerin.jacob@caviumnetworks.com, wenzhuo.lu@intel.com To: Thomas Monjalon Return-path: Received: from mail-it0-f53.google.com (mail-it0-f53.google.com [209.85.214.53]) by dpdk.org (Postfix) with ESMTP id A94ED8E74 for ; Fri, 27 Apr 2018 18:31:58 +0200 (CEST) Received: by mail-it0-f53.google.com with SMTP id 186-v6so2540101itu.0 for ; Fri, 27 Apr 2018 09:31:58 -0700 (PDT) In-Reply-To: <2992884.f5kbt66Nfe@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 27, 2018, 17:22 Thomas Monjalon wrote: > 26/04/2018 08:20, Arnon Warshavsky: > > The purpose of this patch series is to cleanup the library code > > from paths that end up aborting the process, > > and move to checking error values, in order to allow the running process > > perform an orderly teardown or other mitigation of the event. > > > > This patch modifies the majority of rte_panic calls > > under lib and drivers, and replaces them with a log message > > and an error return code according to context, > > that can be propagated up the call stack. > > > > - Focus was given to the dpdk initialization path > > - Some of the panic calls within drivers were left in place where > > the call is from within an interrupt or calls that are > > on the data path,where there is no simple applicative > > route to propagate the error to temination. > > These should be handled by the driver maintainers.. > > - local void functions with no api were changed to retrun a value > > where needed > > - No change took place in example and test files > > - No change took place for debug assertions calling panic > > - A new function was added to devtools/checkpatches.sh > > in order to prevent new additions of calls to rte_panic > > under lib and drivers. > > > > Keep calm and don't panic > > What is the status of this patchset? > It seems not ready for RC1 (today). > I don't want to push it in RC2 because it changes too many things. > So it's today or wait for 18.08. What do you think? > > The last patch for check tooling can be separated and pushed at anytime. > Yes,unfortunately its 18.08.I am away the entire weekend from any means of getting the code fixed, so only on Sunday I will split the last patch from the rest. Should I put the tooling patch as a new set and refer both patchsets to the current v9? > > >