From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnon Warshavsky Subject: Re: [PATCH v9 10/10] devtools: prevent new instances of rte_panic and rte_exit Date: Fri, 27 Apr 2018 00:57:56 +0300 Message-ID: References: <1524663944-30376-11-git-send-email-arnon@qwilt.com> <1524723664-30510-1-git-send-email-arnon@qwilt.com> <1524723664-30510-11-git-send-email-arnon@qwilt.com> <22f61f91-9755-520c-9ba1-d93a312a43e3@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Thomas Monjalon , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org To: Kevin Traynor Return-path: Received: from mail-it0-f47.google.com (mail-it0-f47.google.com [209.85.214.47]) by dpdk.org (Postfix) with ESMTP id D18247EE0 for ; Thu, 26 Apr 2018 23:57:57 +0200 (CEST) Received: by mail-it0-f47.google.com with SMTP id m134-v6so267833itb.3 for ; Thu, 26 Apr 2018 14:57:57 -0700 (PDT) In-Reply-To: <22f61f91-9755-520c-9ba1-d93a312a43e3@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 26, 2018 at 7:08 PM, Kevin Traynor wrote: > I think the first line of the commit msg ^^^ should change as it no > longer prevents but just warns > > Actually the return value did not change, only the warning text did. I would rather keep the word 'prevents' as an intention declaration that puts the fact that a panic is undesired first, and the technical ability of a maintainer to allow it second. This is just in terms of how one positions the usage of panic. > > > > Seems to drop the patch name if it finds a match Not sure I understand what you meant here. Can you please elaborate? Thanks /Arnon