From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnon Warshavsky <arnon@qwilt.com>
Subject: Re: [PATCH v4 07/11] eal: replace rte_panic instances in
	hugepage_info
Date: Thu, 19 Apr 2018 17:09:03 +0300
Message-ID: <CAKy9EB3MhL9RAkSZ-kQFLV5TgKNjSWd8BC1Su4LmPLNbfLi=4A@mail.gmail.com>
References: <1524117669-25729-1-git-send-email-arnon@qwilt.com>
 <1524117669-25729-8-git-send-email-arnon@qwilt.com>
 <9d631c8a-5ec6-aae1-9f5d-0c890dfb1c19@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Thomas Monjalon <thomas@monjalon.net>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "Doherty, Declan" <declan.doherty@intel.com>, jerin.jacob@caviumnetworks.com,
 Bruce Richardson <bruce.richardson@intel.com>, "Yigit,
 Ferruh" <ferruh.yigit@intel.com>, dev@dpdk.org
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-it0-f48.google.com (mail-it0-f48.google.com
 [209.85.214.48]) by dpdk.org (Postfix) with ESMTP id 2AC997CEE
 for <dev@dpdk.org>; Thu, 19 Apr 2018 16:09:05 +0200 (CEST)
Received: by mail-it0-f48.google.com with SMTP id h143-v6so7173334ita.4
 for <dev@dpdk.org>; Thu, 19 Apr 2018 07:09:05 -0700 (PDT)
In-Reply-To: <9d631c8a-5ec6-aae1-9f5d-0c890dfb1c19@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thanks Anatoly. Will fix that in v5.
Is it preferred to keep all version notes in the cover letter alone?

On Thu, Apr 19, 2018 at 5:03 PM, Burakov, Anatoly <anatoly.burakov@intel.com
> wrote:

> On 19-Apr-18 7:01 AM, Arnon Warshavsky wrote:
>
>> replace panic calls with log and retrun value.
>>
>
> typo: return
>
>
>> v4
>> static size calculation function changed to return success/fail code
>> in addition to filling  the size result.
>>
>> Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
>> ---
>>
>
> Please do not add version notes to commit message. You might want to use
> "git notes add" for this, or manually edit the patch and add notes after
> "---" before sending.
>
> On patch contents,
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> --
> Thanks,
> Anatoly
>



-- 

*Arnon Warshavsky*
*Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon@qwilt.com
<arnon@qwilt.com>*