From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnon Warshavsky Subject: Re: [PATCH v7 08/11] eal: replace rte_panic instances in interrupts thread Date: Wed, 25 Apr 2018 12:37:10 +0300 Message-ID: References: <1524608213-2080-1-git-send-email-arnon@qwilt.com> <1524608213-2080-9-git-send-email-arnon@qwilt.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Thomas Monjalon , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org To: "Burakov, Anatoly" Return-path: Received: from mail-io0-f179.google.com (mail-io0-f179.google.com [209.85.223.179]) by dpdk.org (Postfix) with ESMTP id 26BD72BC9 for ; Wed, 25 Apr 2018 11:37:12 +0200 (CEST) Received: by mail-io0-f179.google.com with SMTP id r9-v6so10026048iod.6 for ; Wed, 25 Apr 2018 02:37:12 -0700 (PDT) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Just a general comment - i'm not too familiar with this code, but it looks > like all of these failures will only happen on thread init. Can we make > sure it starts? > > You can use similar approach to Olivier's (recently merged) thread > affinity patches, with pthread barriers etc. to ensure the thread has > initialized properly, pthread_cancel() it if it didn't, and return -1 on > thread init. Thanks for catching this one. I am now reverting it as well from this set, to be properly handled in a set dedicated to the threading issue