From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnon Warshavsky <arnon@qwilt.com>
Subject: Re: [PATCH v9 09/10] eal: replace rte_panic instances in
 init sequence
Date: Fri, 27 Apr 2018 01:08:42 +0300
Message-ID: <CAKy9EB3_udeWHM-e76SOgv6RE9q1VHWvtKPXWHLHSRg3XLLi8A@mail.gmail.com>
References: <1524663944-30376-11-git-send-email-arnon@qwilt.com>
 <1524723664-30510-1-git-send-email-arnon@qwilt.com>
 <1524723664-30510-10-git-send-email-arnon@qwilt.com>
 <621e7964-0450-a66e-cbf3-4fbc3a5ad723@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Thomas Monjalon <thomas@monjalon.net>, "Burakov,
 Anatoly" <anatoly.burakov@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Doherty,
 Declan" <declan.doherty@intel.com>,
 jerin.jacob@caviumnetworks.com, Bruce Richardson <bruce.richardson@intel.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, dev@dpdk.org
To: Kevin Traynor <ktraynor@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-it0-f65.google.com (mail-it0-f65.google.com
 [209.85.214.65]) by dpdk.org (Postfix) with ESMTP id 391587EEF
 for <dev@dpdk.org>; Fri, 27 Apr 2018 00:08:43 +0200 (CEST)
Received: by mail-it0-f65.google.com with SMTP id 144-v6so284255iti.5
 for <dev@dpdk.org>; Thu, 26 Apr 2018 15:08:43 -0700 (PDT)
In-Reply-To: <621e7964-0450-a66e-cbf3-4fbc3a5ad723@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Kevin

> > +     if (rte_config_init() != 0)
> > +             return -1;
> > +
>
> I'm confused, is this deliberate? there is now two rte_config_init()
> calls.


Please note that there are 2 eal.c files. One under linux and one under bsd
There is a copy of rte_config_init() in each.


> Aaron's comments on v4 about rte_eal_init_alert() are missed? and
> it's missing the clear once and error number like the other returns.
>

These comments were for code that I reverted to call panic again.
As Aaron pointed out, the partial treatment of v4 did not only not-improve
things, rather made them worst.
This code along with other panic instances thrown from within threads will
have a dedicated patchset.

Thanks
/Arnon