From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnon Warshavsky <arnon@qwilt.com>
Subject: Re: [PATCH v4 05/11] eal: replace rte_panic instances in
	eventdev
Date: Fri, 20 Apr 2018 16:17:24 +0300
Message-ID: <CAKy9EB3vsFAjTK3wfcxFi+HYv0sHNFMbibRLLzK8Fq63tpCbTA@mail.gmail.com>
References: <1524117669-25729-1-git-send-email-arnon@qwilt.com>
 <1524117669-25729-6-git-send-email-arnon@qwilt.com>
 <34c6e1ec-3890-fcee-1c6d-2eb729339d30@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Thomas Monjalon <thomas@monjalon.net>, "Burakov,
 Anatoly" <anatoly.burakov@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Doherty,
 Declan" <declan.doherty@intel.com>,
 jerin.jacob@caviumnetworks.com, Bruce Richardson <bruce.richardson@intel.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, dev@dpdk.org
To: Kevin Traynor <ktraynor@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-io0-f195.google.com (mail-io0-f195.google.com
 [209.85.223.195]) by dpdk.org (Postfix) with ESMTP id 4886AF988
 for <dev@dpdk.org>; Fri, 20 Apr 2018 15:17:25 +0200 (CEST)
Received: by mail-io0-f195.google.com with SMTP id d24-v6so650706iob.5
 for <dev@dpdk.org>; Fri, 20 Apr 2018 06:17:25 -0700 (PDT)
In-Reply-To: <34c6e1ec-3890-fcee-1c6d-2eb729339d30@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Ok. Thanks

On Thu, Apr 19, 2018 at 8:26 PM, Kevin Traynor <ktraynor@redhat.com> wrote:

> On 04/19/2018 07:01 AM, Arnon Warshavsky wrote:
> > replace panic calls with log and retrun value.
> >
> > --
> > v4 - fix split literal strings in log messages
> >
> > Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
> > ---
> >  lib/librte_eventdev/rte_eventdev_pmd_pci.h  | 8 +++++---
> >  lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +++++---
> >  2 files changed, 10 insertions(+), 6 deletions(-)
> >
> > diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h
> b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
> > index 8fb6138..dad2182 100644
> > --- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h
> > +++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
> > @@ -66,9 +66,11 @@
> >                                               RTE_CACHE_LINE_SIZE,
> >                                               rte_socket_id());
> >
> > -             if (eventdev->data->dev_private == NULL)
> > -                     rte_panic("Cannot allocate memzone for private "
> > -                                     "device data");
> > +             if (eventdev->data->dev_private == NULL) {
> > +                     RTE_LOG(CRIT, EAL, "%s(): Cannot allocate memzone
> for private device data",
> > +                             __func__);
> > +                     return -1;
>
> return -ENOMEM
>
> > +             }
> >       }
> >
> >       eventdev->dev = &pci_dev->device;
> > diff --git a/lib/librte_eventdev/rte_eventdev_pmd_vdev.h
> b/lib/librte_eventdev/rte_eventdev_pmd_vdev.h
> > index 8c64a06..b7c08fa 100644
> > --- a/lib/librte_eventdev/rte_eventdev_pmd_vdev.h
> > +++ b/lib/librte_eventdev/rte_eventdev_pmd_vdev.h
> > @@ -61,9 +61,11 @@
> >                                               RTE_CACHE_LINE_SIZE,
> >                                               socket_id);
> >
> > -             if (eventdev->data->dev_private == NULL)
> > -                     rte_panic("Cannot allocate memzone for private
> device"
> > -                                     " data");
> > +             if (eventdev->data->dev_private == NULL) {
> > +                     RTE_LOG(CRIT, EAL, "%s(): Cannot allocate memzone
> for private device data",
> > +                             __func__);
> > +                     return NULL;
> > +             }
> >       }
> >
> >       return eventdev;
> >
>
>


-- 

*Arnon Warshavsky*
*Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon@qwilt.com
<arnon@qwilt.com>*