From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0002C432BE for ; Wed, 1 Sep 2021 17:21:24 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 1E4CF6101B for ; Wed, 1 Sep 2021 17:21:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1E4CF6101B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E70D4115A; Wed, 1 Sep 2021 19:21:23 +0200 (CEST) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by mails.dpdk.org (Postfix) with ESMTP id A643641142 for ; Wed, 1 Sep 2021 19:21:22 +0200 (CEST) Received: by mail-lf1-f50.google.com with SMTP id c8so514010lfi.3 for ; Wed, 01 Sep 2021 10:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sEYs2eheEzol0bf7uaRVeR0MG+kfn6UW8ExKCymmwk8=; b=HE0BUS6SKFTa1Oq6inK72EcBGzZkhwXST+6o8iRmOmSJ1xLrZEB+Z0L9hfHQt1qbNx gr8e6xj8rtSvAafugCTuGNBNMhsAYTFO/D4FkhM9SbpUov2MKi19OfCT/zLs5jPE3vxc NFFh5KCYDkXgyBSrUhDTmN48xQYz5oHVvLpM4JJEg49lXqM5bCJBR8+xfF29JtgIqU3J nDnZbAf/0UR3wtgZtCzFHKvZCHnZTIoLwAfWdcFbGEn3BFIYjOWqn0S203uAiDyc5RHN veW4Ul7uBX2tZ18q+vkspjAzaUpNKyci9wKE1eCMfa5wcI+YR5W3xV19BqsX7CBdTDfk n0zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sEYs2eheEzol0bf7uaRVeR0MG+kfn6UW8ExKCymmwk8=; b=sCb91Za5pZQlXNpujS+QmsL7YTik5Nz+tvbcMyVd4JozuS6VpAiyiQquLQrFdMnx0y xIU2eAt7w5UdFr/d3a1xjClwe/13eZ6PAdPNhzUkilQdnJ39hEMpGZsf0RFi8Vm/VjtY uJTmsnQzPr/xROmm/e6IbICo/rgUcClAxjIWwLd50rJcjvSYMSgyBkiBOHCoS8UyEc6V 76qnjtXvkPauPxVKt+/Ll5X/QA+Y1R8+VwpHZjsM/sVqVbgqdw4CLDpXfGpeSeJ9zaWR Q8eUZVdBH1Vsy0CXVmA1FzWWWzHU9XFkbLABS+dlfowCBhwhC4sH/gByKwEbos0i/mXA lVTw== X-Gm-Message-State: AOAM5332OFVjjtblytJR3QsJYmOZpEBnLUWH8bqDQptvlePPdj0rb12P y7jSDJ7BZ+JWloQZ0Jq1Uo+oEe3EI5PXTz6wKVI= X-Google-Smtp-Source: ABdhPJxhkpIr2JiKsVfjLdCNg5yAaPhSvmGGJity03e7E7lhiyImigOjoPchuz7AQQ5ZkCsEJyJ9NOUdl0leRbMXqSo= X-Received: by 2002:a19:7916:: with SMTP id u22mr366323lfc.495.1630516882121; Wed, 01 Sep 2021 10:21:22 -0700 (PDT) MIME-Version: 1.0 References: <20210829021602.290466-1-dmitry.kozliuk@gmail.com> <20210829021602.290466-2-dmitry.kozliuk@gmail.com> In-Reply-To: <20210829021602.290466-2-dmitry.kozliuk@gmail.com> From: William Tu Date: Wed, 1 Sep 2021 10:20:45 -0700 Message-ID: To: Dmitry Kozlyuk Cc: dpdk-dev , Thomas Monjalon , Ray Kinsella , David Marchand Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] eal: remove Windows-specific list of common files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Aug 28, 2021 at 7:16 PM Dmitry Kozlyuk wrote: > > The majority of common EAL sources that are built for all platforms were > listed separately for Windows and for other OS. It seems that developers > adding modules to EAL perceived this as if Windows supported > only a limited subset of modules and only added new ones into another. > Factor the truly common modules into a shared list, > then extend it with modules supported by different platforms. > > When the two lists were created, UUID API implementation was removed > from Windows build (apparently by mistake), then excluded from the > export list for no reason other than not being built. Restore it. > > Fixes: df3ff6be2b33 ("eal: simplify meson build of common directory") > Cc: thomas@monjalon.net > > Signed-off-by: Dmitry Kozlyuk > --- LGTM, thanks. Acked-by: William Tu