From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Blunck <jblunck@infradead.org>
Subject: Re: [PATCH v2 09/12] ethdev: support attach vdev in
 secondary process
Date: Thu, 5 Oct 2017 16:26:57 +0200
Message-ID: <CALe+Z00DwQFz4ew4+oHg_2P5QSD_GE1SpGbNuKigUbxgMwmaMQ@mail.gmail.com>
References: <1503654052-84730-1-git-send-email-jianfeng.tan@intel.com>
 <1506606959-76230-1-git-send-email-jianfeng.tan@intel.com>
 <1506606959-76230-10-git-send-email-jianfeng.tan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>,
 yliu@fridaylinux.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
 Tetsuya Mukawa <mtetsuyah@gmail.com>, Ferruh Yigit <ferruh.yigit@intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com
 [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id B1CE31B203
 for <dev@dpdk.org>; Thu,  5 Oct 2017 16:26:58 +0200 (CEST)
Received: by mail-wr0-f195.google.com with SMTP id z1so9710421wre.1
 for <dev@dpdk.org>; Thu, 05 Oct 2017 07:26:58 -0700 (PDT)
In-Reply-To: <1506606959-76230-10-git-send-email-jianfeng.tan@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Sep 28, 2017 at 3:55 PM, Jianfeng Tan <jianfeng.tan@intel.com> wrote:
> When vdev driver requests an ethdev entry in secondary process,
> we will identify the correct entry in rte_eth_dev_data array
> and return the correct entry in the rte_eth_devices arrays.
>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
>  lib/librte_ether/rte_ethdev_vdev.h | 26 +++++++++++++++-----------
>  1 file changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/lib/librte_ether/rte_ethdev_vdev.h b/lib/librte_ether/rte_ethdev_vdev.h
> index 4d2c3e2..460749b 100644
> --- a/lib/librte_ether/rte_ethdev_vdev.h
> +++ b/lib/librte_ether/rte_ethdev_vdev.h
> @@ -58,25 +58,29 @@ rte_eth_vdev_allocate(struct rte_vdev_device *dev, size_t private_data_size)
>         struct rte_eth_dev *eth_dev;
>         const char *name = rte_vdev_device_name(dev);
>
> -       eth_dev = rte_eth_dev_allocate(name);
> -       if (!eth_dev)
> -               return NULL;
> -
> -       if (private_data_size) {
> -               eth_dev->data->dev_private = rte_zmalloc_socket(name,
> -                       private_data_size, RTE_CACHE_LINE_SIZE,
> -                       dev->device.numa_node);
> -               if (!eth_dev->data->dev_private) {
> -                       rte_eth_dev_release_port(eth_dev);
> +       if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> +               eth_dev = rte_eth_dev_allocate(name);
> +               if (!eth_dev)
>                         return NULL;
> +
> +               if (private_data_size) {
> +                       eth_dev->data->dev_private = rte_zmalloc_socket(name,
> +                                       private_data_size, RTE_CACHE_LINE_SIZE,
> +                                       dev->device.numa_node);
> +                       if (!eth_dev->data->dev_private) {
> +                               rte_eth_dev_release_port(eth_dev);
> +                               return NULL;
> +                       }
>                 }
> +       } else {
> +               eth_dev = rte_eth_dev_attach_secondary(name);

I don't see the point why the secondary process should call
rte_eth_vdev_allocate() in the first place. The driver needs to setup
the IPC anyway so it should just call rte_eth_dev_attach_secondary()
instead.


>         }
>
>         eth_dev->device = &dev->device;
>         eth_dev->intr_handle = NULL;
> -
>         eth_dev->data->kdrv = RTE_KDRV_NONE;
>         eth_dev->data->numa_node = dev->device.numa_node;
> +
>         return eth_dev;
>  }
>
> --
> 2.7.4
>