From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Blunck <jblunck@infradead.org>
Subject: Re: [PATCH 2/8] i40e: don't refer to eth_dev->pci_dev
Date: Wed, 11 Jan 2017 08:55:07 +0100
Message-ID: <CALe+Z00UGRgbdZRm=GpHDcM3thOfR5stPWfJoZGLcQLwBViK+w@mail.gmail.com>
References: <20170107181756.1944-1-sthemmin@microsoft.com>
 <20170107181756.1944-3-sthemmin@microsoft.com>
 <CALe+Z01UWj4pTK-9ciyoYsdddHv3+hOGYOf7CWNODnTMSWe57A@mail.gmail.com>
 <20170110095749.3cb00cab@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wj0-f196.google.com (mail-wj0-f196.google.com
 [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id D482DF60C
 for <dev@dpdk.org>; Wed, 11 Jan 2017 08:55:08 +0100 (CET)
Received: by mail-wj0-f196.google.com with SMTP id dh1so9411246wjb.3
 for <dev@dpdk.org>; Tue, 10 Jan 2017 23:55:08 -0800 (PST)
In-Reply-To: <20170110095749.3cb00cab@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jan 10, 2017 at 6:57 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Tue, 10 Jan 2017 13:08:30 +0100
> Jan Blunck <jblunck@infradead.org> wrote:
>
>> On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger
>> <stephen@networkplumber.org> wrote:
>> > Later patches remove pci_dev from the ethernet device structure.
>> > Fix the i40e code to just use it's own name when forming zone name.
>> >
>> > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
>> > ---
>> >  drivers/net/i40e/i40e_fdir.c | 3 +--
>> >  1 file changed, 1 insertion(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
>> > index 335bf15c..68a2523c 100644
>> > --- a/drivers/net/i40e/i40e_fdir.c
>> > +++ b/drivers/net/i40e/i40e_fdir.c
>> > @@ -250,8 +250,7 @@ i40e_fdir_setup(struct i40e_pf *pf)
>> >         }
>> >
>> >         /* reserve memory for the fdir programming packet */
>> > -       snprintf(z_name, sizeof(z_name), "%s_%s_%d",
>> > -                       eth_dev->driver->pci_drv.driver.name,
>> > +       snprintf(z_name, sizeof(z_name), "i40e_%s_%d",
>>
>> The driver is called 'net_i40e'.
>
> It really doesn't matter. The memory name is just so that primary and secondary
> find the same resources.  Having net_ on the front doesn't change or help.

I understand. Still David Marchand just recently went through the
exercise to align all driver names and their usage.

Is there a reason why you didn't choose to use eth_dev->data->drv_name?