From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Blunck <jblunck@infradead.org>
Subject: Re: [PATCH 2/2] vdev: directly use rte_bus reference
Date: Tue, 11 Jul 2017 15:43:46 -0400
Message-ID: <CALe+Z00z=L2+aULzR-pdMzoOBzFP41VEXb8KTf+M60k4nz75NA@mail.gmail.com>
References: <20170711185649.43620-1-jblunck@infradead.org>
 <20170711185649.43620-3-jblunck@infradead.org>
 <20170711190907.GX11154@bidouze.vm.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev <dev@dpdk.org>
To: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com
 [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id E224B2E8B
 for <dev@dpdk.org>; Tue, 11 Jul 2017 21:43:47 +0200 (CEST)
Received: by mail-wr0-f195.google.com with SMTP id x23so584055wrb.0
 for <dev@dpdk.org>; Tue, 11 Jul 2017 12:43:47 -0700 (PDT)
In-Reply-To: <20170711190907.GX11154@bidouze.vm.6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jul 11, 2017 at 3:09 PM, Ga=C3=ABtan Rivet <gaetan.rivet@6wind.com>=
 wrote:
> Hi Jan,
>
> On Tue, Jul 11, 2017 at 02:56:49PM -0400, Jan Blunck wrote:
>> It isn't necessary to use rte_bus_find_by_name() to find a reference to
>> our own bus.
>>
>> Signed-off-by: Jan Blunck <jblunck@infradead.org>
>> ---
>>  lib/librte_eal/common/eal_common_vdev.c | 9 +++++----
>>  1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/co=
mmon/eal_common_vdev.c
>> index 2ca0cdb0f..db69d18c6 100644
>> --- a/lib/librte_eal/common/eal_common_vdev.c
>> +++ b/lib/librte_eal/common/eal_common_vdev.c
>> @@ -47,6 +47,9 @@
>>  #include <rte_memory.h>
>>  #include <rte_errno.h>
>>
>> +/* Forward declare to access virtual bus name */
>> +static struct rte_bus rte_vdev_bus;
>> +
>>  /** Double linked list of virtual device drivers. */
>>  TAILQ_HEAD(vdev_device_list, rte_vdev_device);
>>
>> @@ -138,7 +141,7 @@ alloc_devargs(const char *name, const char *args)
>>       if (!devargs)
>>               return NULL;
>>
>> -     devargs->bus =3D rte_bus_find_by_name("vdev");
>> +     devargs->bus =3D rte_bus_find_by_name(rte_vdev_bus.name);
>
> Why not directly &rte_vdev_bus here?
>

Thanks, will fix.

>>       if (args)
>>               devargs->args =3D strdup(args);
>>
>> @@ -250,13 +253,11 @@ vdev_scan(void)
>>  {
>>       struct rte_vdev_device *dev;
>>       struct rte_devargs *devargs;
>> -     struct rte_bus *vbus;
>>
>>       /* for virtual devices we scan the devargs_list populated via cmdl=
ine */
>> -     vbus =3D rte_bus_find_by_name("vdev");
>>       TAILQ_FOREACH(devargs, &devargs_list, next) {
>>
>> -             if (devargs->bus !=3D vbus)
>> +             if (devargs->bus !=3D &rte_vdev_bus)
>>                       continue;
>>
>>               dev =3D find_vdev(devargs->name);
>> --
>> 2.13.2
>>
>
> --
> Ga=C4=97tan Rivet
> 6WIND