From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Blunck <jblunck@infradead.org>
Subject: Re: [PATCH 1/2] bond: avoid allocating mempool on socket
	LCORE_ID_ANY
Date: Wed, 28 Jun 2017 14:00:14 +0200
Message-ID: <CALe+Z01DGVCYrdGFib_raFX7iSUK0SA_Ve9sg7ZCQVc8bJSnmw@mail.gmail.com>
References: <1493242208-19526-1-git-send-email-jblunck@infradead.org>
 <44751a6e-4a2c-a53e-3fdc-89a95be3f5f3@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: "dev@dpdk.org" <dev@dpdk.org>, Eric Kinzie <ehkinzie@gmail.com>
To: Declan Doherty <declan.doherty@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65])
 by dpdk.org (Postfix) with ESMTP id 84C802C13
 for <dev@dpdk.org>; Wed, 28 Jun 2017 14:00:15 +0200 (CEST)
Received: by mail-wm0-f65.google.com with SMTP id 131so11055706wmq.2
 for <dev@dpdk.org>; Wed, 28 Jun 2017 05:00:15 -0700 (PDT)
In-Reply-To: <44751a6e-4a2c-a53e-3fdc-89a95be3f5f3@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jun 28, 2017 at 11:47 AM, Declan Doherty
<declan.doherty@intel.com> wrote:
> On 26/04/17 22:30, Jan Blunck wrote:
>>
>> If the numa node is unknown, use the value from rte_socket_id() to avoid
>> an allocation failure.
>>
>> Signed-off-by: Eric Kinzie <ekinzie@brocade.com>
>> CC: Eric Kinzie <ehkinzie@gmail.com>
>> ---
>>   drivers/net/bonding/rte_eth_bond_8023ad.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c
>> b/drivers/net/bonding/rte_eth_bond_8023ad.c
>> index 7b863d6..b8df536 100644
>> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
>> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
>> @@ -887,6 +887,8 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev
>> *bond_dev, uint8_t slave_id)
>>         RTE_ASSERT(port->rx_ring == NULL);
>>         RTE_ASSERT(port->tx_ring == NULL);
>>         socket_id = rte_eth_devices[slave_id].data->numa_node;
>> +       if (socket_id == (uint8_t)LCORE_ID_ANY)
>
>
> socket_id is an integer so we shouldn't be casting LCORE_ID_ANY to an
> uint8_t as this condition would never match as LCORE_ID_ANY wouldn't be
> UINT32_MAX after casting
>

Ouch ... let me fix this.

>> +               socket_id = 0;
>
>
> Should this not be socket_id = rte_socket_id(); as we don't know we are
> running on
>
>
>>         element_size = sizeof(struct slow_protocol_frame) +
>>                                 RTE_PKTMBUF_HEADROOM;
>>
>