From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Blunck <jblunck@infradead.org>
Subject: Re: [PATCH 6/7] eal: add struct rte_vdev_device
Date: Thu, 16 Feb 2017 16:55:52 +0100
Message-ID: <CALe+Z02+MPjDtybvJP7XmxLYaU5ExgJ_94sMwgQOmJeMia4owQ@mail.gmail.com>
References: <1487152929-23627-1-git-send-email-jblunck@infradead.org>
 <1487152929-23627-7-git-send-email-jblunck@infradead.org>
 <e55c554c-a13d-bfd5-dd9f-772ea7998423@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: dev <dev@dpdk.org>, Shreyansh Jain <shreyansh.jain@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65])
 by dpdk.org (Postfix) with ESMTP id 4AC5047CD
 for <dev@dpdk.org>; Thu, 16 Feb 2017 16:55:53 +0100 (CET)
Received: by mail-wm0-f65.google.com with SMTP id c85so3799239wmi.1
 for <dev@dpdk.org>; Thu, 16 Feb 2017 07:55:53 -0800 (PST)
In-Reply-To: <e55c554c-a13d-bfd5-dd9f-772ea7998423@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Feb 15, 2017 at 6:11 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 2/15/2017 10:02 AM, Jan Blunck wrote:
>> This adds the rte_vdev_device structure which embeds a generic rte_device.
>>
>> Signed-off-by: Jan Blunck <jblunck@infradead.org>
>
> <...>
>
>>
>> +struct rte_vdev_device {
>> +     TAILQ_ENTRY(rte_vdev_device) next;      /**< Next attached vdev */
>> +     struct rte_device device;               /**< Inherit core device */
>
> What do you think adding a name field here ?
>
> "dev->device.devargs->virt.drv_name" used a few times, since probing
> virtual devices done based on name.
>
> This is device name, and accessing it via "devargs->virt.drv_name" is
> not that clear. It is possible to create a name field here, set it
> during probe or init to point devargs field and use it wherever
> required, does it make sense?
>

Why don't we add such a thing to the generic rte_device instead? While
we are at it we might want to also add a driver private data field.

Thoughts?