From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Blunck <jblunck@infradead.org>
Subject: Re: [PATCH v5 20/20] ethdev: Decouple from PCI device
Date: Fri, 23 Dec 2016 17:20:39 +0100
Message-ID: <CALe+Z02Ms2sgi9HYDxvxxxfO-LoWE3H34HxqwVMpo3VxD1fnpQ@mail.gmail.com>
References: <1482508691-11408-1-git-send-email-jblunck@infradead.org>
 <1482508691-11408-21-git-send-email-jblunck@infradead.org>
 <2185678.prfkkk662h@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: dev@dpdk.org, Shreyansh Jain <shreyansh.jain@nxp.com>,
 David Marchand <david.marchand@6wind.com>,
 Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66])
 by dpdk.org (Postfix) with ESMTP id 2BB932B9F
 for <dev@dpdk.org>; Fri, 23 Dec 2016 17:20:40 +0100 (CET)
Received: by mail-wm0-f66.google.com with SMTP id m203so42298719wma.3
 for <dev@dpdk.org>; Fri, 23 Dec 2016 08:20:40 -0800 (PST)
In-Reply-To: <2185678.prfkkk662h@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Dec 23, 2016 at 5:17 PM, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> 2016-12-23 16:58, Jan Blunck:
>> +/**
>> + * @internal
>> + * Helper macro for drivers that need to convert to struct rte_pci_device.
>> + */
>> +#define RTE_DEV_PCI_DEV(ptr) container_of(ptr, struct rte_pci_device, device)
>
> Do you prefer to rename to RTE_DEV_TO_PCI?

I'm fine with that.

>
>> +       struct rte_device *device; /**< Backing device for this device */
>
> This comment looks strange.
> shorten to just "Backing device"?

Agreed.