From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Blunck <jblunck@infradead.org>
Subject: Re: [PATCH 5/8] nfp: don't refer to eth_dev->pci_dev
Date: Tue, 10 Jan 2017 13:13:52 +0100
Message-ID: <CALe+Z03NpkpeOaff_8n3Z9Q-hMOW2HQODC_0YgQH+j48H6_7Sg@mail.gmail.com>
References: <20170107181756.1944-1-sthemmin@microsoft.com>
 <20170107181756.1944-6-sthemmin@microsoft.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65])
 by dpdk.org (Postfix) with ESMTP id 4C15528F3
 for <dev@dpdk.org>; Tue, 10 Jan 2017 13:13:53 +0100 (CET)
Received: by mail-wm0-f65.google.com with SMTP id c85so29074505wmi.1
 for <dev@dpdk.org>; Tue, 10 Jan 2017 04:13:53 -0800 (PST)
In-Reply-To: <20170107181756.1944-6-sthemmin@microsoft.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> Later patches remove pci_dev from the ethernet device structure.
> Fix the nfp code to just use it's own name when forming zone name.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
>  drivers/net/nfp/nfp_net.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> index e85315f1..970b5c84 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -213,8 +213,7 @@ ring_dma_zone_reserve(struct rte_eth_dev *dev, const char *ring_name,
>         char z_name[RTE_MEMZONE_NAMESIZE];
>         const struct rte_memzone *mz;
>
> -       snprintf(z_name, sizeof(z_name), "%s_%s_%d_%d",
> -                dev->driver->pci_drv.driver.name,
> +       snprintf(z_name, sizeof(z_name), "nfp_%s_%u_%u",
>                  ring_name, dev->data->port_id, queue_id);
>

The driver is called 'net_nfp'.

>         mz = rte_memzone_lookup(z_name);
> @@ -1009,7 +1008,6 @@ nfp_net_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>         hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);
>
>         dev_info->pci_dev = RTE_DEV_TO_PCI(dev->device);
> -       dev_info->driver_name = dev->driver->pci_drv.driver.name;
>         dev_info->max_rx_queues = (uint16_t)hw->max_rx_queues;
>         dev_info->max_tx_queues = (uint16_t)hw->max_tx_queues;
>         dev_info->min_rx_bufsize = ETHER_MIN_MTU;
> --
> 2.11.0
>