From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Blunck <jblunck@infradead.org>
Subject: Re: [PATCH v3 02/10] eal: probe new virtual bus after
	other bus devices
Date: Mon, 27 Feb 2017 10:09:05 +0100
Message-ID: <CALe+Z03mdGSK7Q_1Fu33Fr6pLHttd0UCC+9CO=bsWSPJBVSSUQ@mail.gmail.com>
References: <1488018496-995-1-git-send-email-jblunck@infradead.org>
 <1488018496-995-3-git-send-email-jblunck@infradead.org>
 <303005d0-f852-f252-7131-8ef6311917a9@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: dev <dev@dpdk.org>, David Marchand <david.marchand@6wind.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com
 [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 6CD1698
 for <dev@dpdk.org>; Mon, 27 Feb 2017 10:09:06 +0100 (CET)
Received: by mail-wr0-f194.google.com with SMTP id g10so9268467wrg.0
 for <dev@dpdk.org>; Mon, 27 Feb 2017 01:09:06 -0800 (PST)
In-Reply-To: <303005d0-f852-f252-7131-8ef6311917a9@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Feb 27, 2017 at 9:59 AM, Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
> On Saturday 25 February 2017 03:58 PM, Jan Blunck wrote:
>>
>> Also see commit f4ce209a ("eal: postpone vdev initialization").
>>
>> Signed-off-by: Jan Blunck <jblunck@infradead.org>
>> ---
>>  lib/librte_eal/common/eal_common_bus.c | 16 +++++++++++++++-
>>  1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_eal/common/eal_common_bus.c
>> b/lib/librte_eal/common/eal_common_bus.c
>> index 4638e78..8f9baf8 100644
>> --- a/lib/librte_eal/common/eal_common_bus.c
>> +++ b/lib/librte_eal/common/eal_common_bus.c
>> @@ -86,9 +86,14 @@ int
>>  rte_bus_probe(void)
>>  {
>>         int ret;
>> -       struct rte_bus *bus;
>> +       struct rte_bus *bus, *vbus = NULL;
>>
>>         TAILQ_FOREACH(bus, &rte_bus_list, next) {
>> +               if (!strcmp(bus->name, "virtual")) {
>> +                       vbus = bus;
>> +                       continue;
>> +               }
>> +
>>                 ret = bus->probe();
>>                 if (ret) {
>>                         RTE_LOG(ERR, EAL, "Bus (%s) probe failed.\n",
>> @@ -97,6 +102,15 @@ rte_bus_probe(void)
>>                 }
>>         }
>>
>> +       if (vbus) {
>> +               ret = vbus->probe();
>> +               if (ret) {
>> +                       RTE_LOG(ERR, EAL, "Bus (%s) probe failed.\n",
>> +                               vbus->name);
>> +                       return ret;
>> +               }
>> +       }
>> +
>
>
> This has probably changed to do away with priority of RTE_REGISTER_*
> macro.
>
> This is based on an assumption that there is only a single 'virtual'
> bus and no driver ever registers another bus with the same name.
>
> The problem originates from the fact that rte_bus_register is
> _not_ checking for duplicate entries while registering.
> (Apparently, it would be a problem in case of RTE_* macros as well).
>
> I think that should be fixed.
>
> If we are in sync, I will push a patch.
>

Indeed. The buses should have a unique name.