From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH v3] ethdev: replace bus specific struct with generic dev Date: Fri, 30 Mar 2018 08:44:56 +0200 Message-ID: References: <20180329145048.123662-1-ferruh.yigit@intel.com> <20180329175206.127943-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: dev@dpdk.org To: Ferruh Yigit Return-path: Received: from mail-it0-f67.google.com (mail-it0-f67.google.com [209.85.214.67]) by dpdk.org (Postfix) with ESMTP id 8CAA94C92 for ; Fri, 30 Mar 2018 08:45:18 +0200 (CEST) Received: by mail-it0-f67.google.com with SMTP id 19-v6so10487930itw.3 for ; Thu, 29 Mar 2018 23:45:18 -0700 (PDT) In-Reply-To: <20180329175206.127943-1-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Ferruh, On Thu, Mar 29, 2018 at 7:52 PM, Ferruh Yigit wrote: > Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it > although it is common for all ethdev in all buses. > > Replacing pci specific struct with generic device struct and updating > places that are using pci device in a way to get this information from > generic device. > > Signed-off-by: Ferruh Yigit > Acked-by: Shreyansh Jain > Acked-by: Allain Legacy > Acked-by: Tomasz Duszynski > Acked-by: Santosh Shukla The ethdev device already points to the backing device. So, can't this be done in the ethdev layer itself ? -- David Marchand