From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand@6wind.com>
Subject: Re: [PATCH 2/3] net/ixgbe: fix build issue
Date: Thu, 26 Oct 2017 12:36:06 +0200
Message-ID: <CALwxeUsOAA8KOtSLT0RqNNRa3UW4s=g9ddDKkFEAyRijQbVkLQ@mail.gmail.com>
References: <1509013365-13819-1-git-send-email-radu.nicolau@intel.com>
 <1509013365-13819-3-git-send-email-radu.nicolau@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: "dev@dpdk.org" <dev@dpdk.org>, Declan Doherty <declan.doherty@intel.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 borisp@mellanox.com, aviadye@mellanox.com,
 Thomas Monjalon <thomas@monjalon.net>, sandeep.malik@nxp.com,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Mcnamara,
 John" <john.mcnamara@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, shahafs@mellanox.com,
 Olivier Matz <olivier.matz@6wind.com>, Akhil Goyal <akhil.goyal@nxp.com>
To: Radu Nicolau <radu.nicolau@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-io0-f193.google.com (mail-io0-f193.google.com
 [209.85.223.193]) by dpdk.org (Postfix) with ESMTP id 586981BAA3
 for <dev@dpdk.org>; Thu, 26 Oct 2017 12:36:27 +0200 (CEST)
Received: by mail-io0-f193.google.com with SMTP id m81so4284631ioi.13
 for <dev@dpdk.org>; Thu, 26 Oct 2017 03:36:27 -0700 (PDT)
In-Reply-To: <1509013365-13819-3-git-send-email-radu.nicolau@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau <radu.nicolau@intel.com> wrote:
> Build fails when rte_security is disabled; make rte_security mandatory
> Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec")
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
>  drivers/net/ixgbe/Makefile | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> index f03c426..c879828 100644
> --- a/drivers/net/ixgbe/Makefile
> +++ b/drivers/net/ixgbe/Makefile
> @@ -31,6 +31,12 @@
>
>  include $(RTE_SDK)/mk/rte.vars.mk
>
> +ifneq ($(MAKECMDGOALS),clean)
> +ifneq ($(CONFIG_RTE_LIBRTE_SECURITY),y)
> +$(error "RTE_LIBRTE_SECURITY is required to build RTE_LIBRTE_IXGBE_PMD")
> +endif
> +endif
> +
>  #
>  # library name
>  #

This is a no go for me unless you explain how it is impossible to
disable it in the code.


-- 
David Marchand