From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand@6wind.com>
Subject: Re: [PATCH 2/4] eal: set kdrv to RTE_KDRV_NONE if kernel
 driver isn't manipulating the device.
Date: Mon, 28 Dec 2015 21:24:10 +0100
Message-ID: <CALwxeUsRO-x2NUYmwMGZrXrNeL1pMqBYEhm+V0eJVbpP0ypoqQ@mail.gmail.com>
References: <20151222035041.GA7532@pxdev.xzpeter.org>
 <1450982292-129560-1-git-send-email-huawei.xie@intel.com>
 <1450982292-129560-3-git-send-email-huawei.xie@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Huawei Xie <huawei.xie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-oi0-f52.google.com (mail-oi0-f52.google.com
 [209.85.218.52]) by dpdk.org (Postfix) with ESMTP id BD6578E9E
 for <dev@dpdk.org>; Mon, 28 Dec 2015 21:24:10 +0100 (CET)
Received: by mail-oi0-f52.google.com with SMTP id o124so178939840oia.1
 for <dev@dpdk.org>; Mon, 28 Dec 2015 12:24:10 -0800 (PST)
In-Reply-To: <1450982292-129560-3-git-send-email-huawei.xie@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Dec 24, 2015 at 7:38 PM, Huawei Xie <huawei.xie@intel.com> wrote:

> Use RTE_KDRV_NONE to indicate that kernel driver isn't manipulating the
> device.
>
> Signed-off-by: Huawei Xie <huawei.xie@intel.com>
> ---
>  lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c
> b/lib/librte_eal/linuxapp/eal/eal_pci.c
> index bc5b5be..640b190 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
> @@ -362,7 +362,7 @@ pci_scan_one(const char *dirname, uint16_t domain,
> uint8_t bus,
>                 else
>                         dev->kdrv = RTE_KDRV_UNKNOWN;
>         } else
> -               dev->kdrv = RTE_KDRV_UNKNOWN;
> +               dev->kdrv = RTE_KDRV_NONE;
>
>         /* device is valid, add in list (sorted) */
>         if (TAILQ_EMPTY(&pci_device_list)) {
> --
> 1.8.1.4
>
>
lgtm
Acked-by: David Marchand <david.marchand@6wind.com>


-- 
David Marchand