From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH 1/3] net/ixgbe: move PCI device ids to the driver Date: Mon, 8 Aug 2016 08:36:17 +0200 Message-ID: References: <1470406171-24754-1-git-send-email-ferruh.yigit@intel.com> <1470406171-24754-2-git-send-email-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" , Helin Zhang , Konstantin Ananyev , Wenzhuo Lu , Thomas Monjalon To: Ferruh Yigit Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 9CCB42931 for ; Mon, 8 Aug 2016 08:36:38 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id q128so99562190wma.1 for ; Sun, 07 Aug 2016 23:36:38 -0700 (PDT) In-Reply-To: <1470406171-24754-2-git-send-email-ferruh.yigit@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Ferruh, On Fri, Aug 5, 2016 at 4:09 PM, Ferruh Yigit wrote: > PCI device ids moved from common header into ixgbe driver itself. > > KNI starts using pci_device_id from kni/ethtool/ixgbe driver, this is > only for KNI ethtool support, KNI data path is not effected. > > Signed-off-by: Ferruh Yigit Thanks for working on this. The only thing that bothers me using this ("unsynchronised") internal pci device list is that, if people were using the ethtool part of kni, there would now be devices that won't be recognised anymore. Is it intentional ? If so, we should explain why in the documentation. Same comment for the igb patch. -- David Marchand