From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand@6wind.com>
Subject: Re: [PATCH] pci: Don't call probe callback if driver
 already loaded.
Date: Thu, 27 Oct 2016 15:28:03 +0200
Message-ID: <CALwxeUtVUNuvKdyk9Y2EW5-MbrEi8W8e2YV3P39m_NGf8NbN0g@mail.gmail.com>
References: <1477432240-20406-1-git-send-email-benjamin.walker@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Ben Walker <benjamin.walker@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id ACD833B5
 for <dev@dpdk.org>; Thu, 27 Oct 2016 15:28:24 +0200 (CEST)
Received: by mail-wm0-f51.google.com with SMTP id e69so34919001wmg.0
 for <dev@dpdk.org>; Thu, 27 Oct 2016 06:28:24 -0700 (PDT)
In-Reply-To: <1477432240-20406-1-git-send-email-benjamin.walker@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Benjamin,

On Tue, Oct 25, 2016 at 11:50 PM, Ben Walker <benjamin.walker@intel.com> wrote:
> If the user asks to probe multiple times, the probe
> callback should only be called on devices that don't have
> a driver already loaded.
>
> This is useful if a driver is registered after the
> execution of a program has started and the list of devices
> needs to be re-scanned.

Why not use the hotplug api, attaching explicitely one pci device ?


> Signed-off-by: Ben Walker <benjamin.walker@intel.com>
> ---
>  lib/librte_eal/common/eal_common_pci.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
> index 638cd86..971ad20 100644
> --- a/lib/librte_eal/common/eal_common_pci.c
> +++ b/lib/librte_eal/common/eal_common_pci.c
> @@ -289,6 +289,10 @@ pci_probe_all_drivers(struct rte_pci_device *dev)
>         if (dev == NULL)
>                 return -1;
>
> +       /* Check if a driver is already loaded */
> +       if (dev->driver != NULL)
> +               return 0;
> +

This can do the trick, yes.

To be safe, I think we are missing a check in
rte_eal_pci_probe_one_driver() so that dev->driver is only set when
the probe function from the driver did succeed.


-- 
David Marchand