From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH 3/3] app/testpmd: add sanity checks on received/sent packets Date: Tue, 25 Sep 2018 17:11:11 +0200 Message-ID: References: <20180910054547.18494-1-david.marchand@6wind.com> <20180910054547.18494-4-david.marchand@6wind.com> <8CEF83825BEC744B83065625E567D7C260CF34F5@IRSMSX107.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: "dev@dpdk.org" , "olivier.matz@6wind.com" , "Lu, Wenzhuo" , "Wu, Jingjing" To: "Iremonger, Bernard" Return-path: Received: from mail-yw1-f68.google.com (mail-yw1-f68.google.com [209.85.161.68]) by dpdk.org (Postfix) with ESMTP id 11B581B1C3 for ; Tue, 25 Sep 2018 17:11:33 +0200 (CEST) Received: by mail-yw1-f68.google.com with SMTP id s73-v6so970639ywg.11 for ; Tue, 25 Sep 2018 08:11:32 -0700 (PDT) In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CF34F5@IRSMSX107.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 25, 2018 at 3:17 PM, Iremonger, Bernard wrote: > Hi David, > >> -----Original Message----- >> From: David Marchand [mailto:david.marchand@6wind.com] >> Sent: Monday, September 10, 2018 6:46 AM >> To: dev@dpdk.org >> Cc: olivier.matz@6wind.com; Lu, Wenzhuo ; Wu, >> Jingjing ; Iremonger, Bernard >> >> Subject: [PATCH 3/3] app/testpmd: add sanity checks on received/sent >> packets >> >> Make use of the newly introduced rte_mbuf_check() to (optionally) check all >> packets received/sent through a port. >> The idea behind this is to help to quickly identify badly formatted mbufs >> coming from the pmd on the rx side, and from the application on the tx side. >> Setting the verbose level to some > 0 value will dump all packets in the >> associated rx/tx callback to further help in the debugging. >> >> Signed-off-by: David Marchand >> --- >> app/test-pmd/cmdline.c | 63 +++++++++++++++++++ >> app/test-pmd/config.c | 23 +++++++ >> app/test-pmd/parameters.c | 7 +++ >> app/test-pmd/testpmd.c | 123 >> ++++++++++++++++++++++++++++++++++++++ >> app/test-pmd/testpmd.h | 9 +++ >> 5 files changed, 225 insertions(+) > > There should probably be an entry in section 4.6 of the Testpmd User Guide for the > "port config all sanity_check" command. Sure, will do. -- David Marchand