From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH] eal: fix cpu_feature_table[] compilation with -pedantic Date: Mon, 29 Jun 2015 14:10:18 +0200 Message-ID: References: <6446943.entjzpE8eR@xps13> <1435570492-19291-1-git-send-email-adrien.mazarguil@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" To: Adrien Mazarguil Return-path: Received: from mail-oi0-f47.google.com (mail-oi0-f47.google.com [209.85.218.47]) by dpdk.org (Postfix) with ESMTP id 24E94C48C for ; Mon, 29 Jun 2015 14:10:19 +0200 (CEST) Received: by oigb199 with SMTP id b199so116312778oig.3 for ; Mon, 29 Jun 2015 05:10:18 -0700 (PDT) In-Reply-To: <1435570492-19291-1-git-send-email-adrien.mazarguil@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 29, 2015 at 11:34 AM, Adrien Mazarguil < adrien.mazarguil@6wind.com> wrote: > Since the commit below includes rte_cpuflags.h in rte_spinlock.h, > compilation of the mlx4 driver fails when CONFIG_RTE_LIBRTE_MLX4_DEBUG=y. > > This mode adds -pedantic to the compiler's command line for mlx4, which > complains about the static definition of an empty cpu_feature_table[] in > common rte_cpuflags.h, then about its redefinition as a larger array in > arch-specific rte_cpuflags.h. > > While DPDK does not officially support -pedantic internally, external > applications may enable it and include rte_spinlock.h from the public API. > > Instead of removing -pedantic from mlx4, this commit fixes rte_cpuflags.h. > > Fixes: ba7468997ea6 ("spinlock: add HTM lock elision for x86") > > Signed-off-by: Adrien Mazarguil > Acked-by: David Marchand -- David Marchand