From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH 1/3] net/ixgbe: move PCI device ids to the driver Date: Wed, 10 Aug 2016 14:07:03 +0200 Message-ID: References: <1470406171-24754-1-git-send-email-ferruh.yigit@intel.com> <1470406171-24754-2-git-send-email-ferruh.yigit@intel.com> <57A84C89.7050107@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" , Helin Zhang , Konstantin Ananyev , Wenzhuo Lu , Thomas Monjalon To: Ferruh Yigit Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 867FD2BDB for ; Wed, 10 Aug 2016 14:07:24 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id o80so99122593wme.1 for ; Wed, 10 Aug 2016 05:07:24 -0700 (PDT) In-Reply-To: <57A84C89.7050107@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 8, 2016 at 11:10 AM, Ferruh Yigit wrote: > On 8/8/2016 7:36 AM, David Marchand wrote: >> The only thing that bothers me using this ("unsynchronised") internal >> pci device list is that, if people were using the ethtool part of kni, >> there would now be devices that won't be recognised anymore. >> Is it intentional ? > > I am aware that the list changed, but wasn't sure about updating the > list in drivers or not. > > If a device is not listed in driver's pci device id table, it may not be > supported, so ethtool may give wrong output, or it may just be missing, > this is hard to know without testing (although this was the case before > this patch) > > Since it is easy to add new id, and we are at the beginning of the > release, I was thinking if somebody reports KNI ethotool support is > missing for a specific device, we can add it instead of adding all by > default. Ok for me and with this we can know if this ethtool part is used :-) -- David Marchand