From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand@6wind.com>
Subject: Re: [PATCH v13] devtools: alert on new instances of
 rte_panic and rte_exit
Date: Mon, 10 Sep 2018 08:06:21 +0200
Message-ID: <CALwxeUtxeBtQyx2Sz8uVxOrToMvZ4PENEUJKCZML1b5AMhxG+g@mail.gmail.com>
References: <1531745044-19185-1-git-send-email-arnon@qwilt.com>
 <1532643058-21027-1-git-send-email-arnon@qwilt.com> <7301022.qQQo3EDiVl@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, Declan Doherty <declan.doherty@intel.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, Arnon Warshavsky <arnon@qwilt.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-yw1-f67.google.com (mail-yw1-f67.google.com
 [209.85.161.67]) by dpdk.org (Postfix) with ESMTP id BABBF4C95
 for <dev@dpdk.org>; Mon, 10 Sep 2018 08:06:42 +0200 (CEST)
Received: by mail-yw1-f67.google.com with SMTP id q129-v6so7431903ywg.8
 for <dev@dpdk.org>; Sun, 09 Sep 2018 23:06:42 -0700 (PDT)
In-Reply-To: <7301022.qQQo3EDiVl@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jul 31, 2018 at 2:38 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
> 27/07/2018 00:10, Arnon Warshavsky:
>> This patch adds a new function that is called
>> per every checked patch,
>> and alerts for new instances of rte_panic/rte_exit.
>> The check excludes comments, and alerts in the case
>> of a positive balance between additions and removals.
>>
>> Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
>> Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
>> Tested-by: Kevin Traynor <ktraynor@redhat.com>
>
> Applied, with small adjustments, thanks

I get some warning when running this on Ubuntu 18.04.

marchand@gribouille:~/git/dpdk$ ./devtools/checkpatches.sh
sanity/0001-mbuf-add-sanity-checks-on-segment-metadata.patch
./devtools/checkpatches.sh: 52: read: Illegal option -d

1/1 valid patch


+ false
+ check_forbidden_additions
+ read -d  awk_script
./devtools/checkpatches.sh: 52: read: Illegal option -d
+ awk -v FOLDERS=lib drivers -v EXPRESSIONS=rte_panic\\( rte_exit\\(
-v RET_ON_FAIL=1  -
+ report=
+ [ 0 -ne 0 ]


-- 
David Marchand