From: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Thomas Monjalon
<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH] pci: rename passthrough driver to kernel driver
Date: Wed, 1 Apr 2015 07:23:17 +0200 [thread overview]
Message-ID: <CALwxeUtxfcrU-gKyA37qZDCsWipE1mcaNS338yOsUuJB0YnPyQ@mail.gmail.com> (raw)
In-Reply-To: <1427839547-14705-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Hello Thomas,
On Wed, Apr 1, 2015 at 12:05 AM, Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
wrote:
> Kernel driver (kdrv) seems easier to understand than
> passthrough driver (pt_driver). It's also more generic
> as a PMD could run on top of any PCI kernel driver if
> it would offer such support.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> ---
> lib/librte_eal/bsdapp/eal/eal_pci.c | 3 +--
> lib/librte_eal/common/include/rte_pci.h | 12 ++++++------
> lib/librte_eal/linuxapp/eal/eal_pci.c | 33
> ++++++++++++++++-----------------
> lib/librte_ether/rte_ethdev.c | 8 ++++----
> 4 files changed, 27 insertions(+), 29 deletions(-)
>
This looks ok for me.
I suppose you checked it builds fine on both linux and bsd ?
Acked-by: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
--
David Marchand
next prev parent reply other threads:[~2015-04-01 5:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 22:05 [PATCH] pci: rename passthrough driver to kernel driver Thomas Monjalon
2015-04-01 2:12 ` Qiu, Michael
[not found] ` <1427839547-14705-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-04-01 5:23 ` David Marchand [this message]
[not found] ` <CALwxeUtxfcrU-gKyA37qZDCsWipE1mcaNS338yOsUuJB0YnPyQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-01 19:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUtxfcrU-gKyA37qZDCsWipE1mcaNS338yOsUuJB0YnPyQ@mail.gmail.com \
--to=david.marchand-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).