From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH] pci: rename passthrough driver to kernel driver Date: Wed, 1 Apr 2015 07:23:17 +0200 Message-ID: References: <1427839547-14705-1-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Thomas Monjalon Return-path: In-Reply-To: <1427839547-14705-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hello Thomas, On Wed, Apr 1, 2015 at 12:05 AM, Thomas Monjalon wrote: > Kernel driver (kdrv) seems easier to understand than > passthrough driver (pt_driver). It's also more generic > as a PMD could run on top of any PCI kernel driver if > it would offer such support. > > Signed-off-by: Thomas Monjalon > --- > lib/librte_eal/bsdapp/eal/eal_pci.c | 3 +-- > lib/librte_eal/common/include/rte_pci.h | 12 ++++++------ > lib/librte_eal/linuxapp/eal/eal_pci.c | 33 > ++++++++++++++++----------------- > lib/librte_ether/rte_ethdev.c | 8 ++++---- > 4 files changed, 27 insertions(+), 29 deletions(-) > This looks ok for me. I suppose you checked it builds fine on both linux and bsd ? Acked-by: David Marchand -- David Marchand