From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand@6wind.com>
Subject: Re: [PATCH v2 5/7] eal: bring forward init of interrupt
	handling
Date: Fri, 13 Jul 2018 13:28:47 +0200
Message-ID: <CALwxeUu7kHf5VUhNu3CtWELkR1sa4-ggke1xpdArwticS99Qig@mail.gmail.com>
References: <cover.1530009564.git.anatoly.burakov@intel.com>
 <5f6bc60bf193daf4eb07f4484c52878bb1b751de.1530009564.git.anatoly.burakov@intel.com>
 <5431396.k1M6VaMcRs@xps>
 <CALwxeUvx2UXSQLTQrSiBZvOEEqmgz9NBUxnEPxJndLcdb_2w3Q@mail.gmail.com>
 <20180713091042.GA21549@debian>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Thomas Monjalon <thomas@monjalon.net>,
 Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org,
 Jianfeng Tan <jianfeng.tan@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, qi.z.zhang@intel.com,
 Stephen Hemminger <stephen@networkplumber.org>,
 Olivier Matz <olivier.matz@6wind.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-yw0-f193.google.com (mail-yw0-f193.google.com
 [209.85.161.193]) by dpdk.org (Postfix) with ESMTP id 6FC6E3238
 for <dev@dpdk.org>; Fri, 13 Jul 2018 13:29:08 +0200 (CEST)
Received: by mail-yw0-f193.google.com with SMTP id l189-v6so11597097ywb.10
 for <dev@dpdk.org>; Fri, 13 Jul 2018 04:29:08 -0700 (PDT)
In-Reply-To: <20180713091042.GA21549@debian>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jul 13, 2018 at 11:10 AM, Tiwei Bie <tiwei.bie@intel.com> wrote:
> On Fri, Jul 13, 2018 at 10:09:42AM +0200, David Marchand wrote:
> [...]
>> Well, there was an issue vith virtio at one time (interrupt handler
>> did not have the right iopl for virtio callback).
>> http://git.dpdk.org/dpdk/commit/lib/librte_eal/linuxapp/eal/eal.c?id=fd6949c55c9a48e81c625138679159829d51ac51
>>
>> Now... time has passed since then.
>> It is worth checking the issue is still here, and if it is the case,
>> revisit this.
>
> Now rte_virtio_pmd_init() which calls rte_eal_iopl_init()
> is called as a constructor [1], so the issue isn't there
> any more.

If the virtio pmd is loaded dynamically, eal_plugins_init() is still
called before rte_eal_intr_init().
Yes, for this case, it looks to be fine with Anatoly change.


-- 
David Marchand