From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand@6wind.com>
Subject: Re: [PATCH v2] ethdev: make default behavior CRC strip
	on Rx
Date: Wed, 19 Sep 2018 09:34:58 +0200
Message-ID: <CALwxeUuAvjjCc9CJvaWqdV0XvhmFo=yWCUK8teebu2Z4HtukMQ@mail.gmail.com>
References: <20180903144501.31373-1-ferruh.yigit@intel.com>
 <20180904101257.61129-1-ferruh.yigit@intel.com>
 <DB7PR05MB442643D0A61E46F2A9642223C3030@DB7PR05MB4426.eurprd05.prod.outlook.com>
 <a7389432-1492-d836-5dcc-9919193b9c9c@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Shahaf Shuler <shahafs@mellanox.com>,
 Thomas Monjalon <thomasm@mellanox.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-yb1-f193.google.com (mail-yb1-f193.google.com
 [209.85.219.193]) by dpdk.org (Postfix) with ESMTP id A18D81041
 for <dev@dpdk.org>; Wed, 19 Sep 2018 09:35:21 +0200 (CEST)
Received: by mail-yb1-f193.google.com with SMTP id w80-v6so1977685ybe.10
 for <dev@dpdk.org>; Wed, 19 Sep 2018 00:35:21 -0700 (PDT)
In-Reply-To: <a7389432-1492-d836-5dcc-9919193b9c9c@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Ferruh,

On Fri, Sep 14, 2018 at 1:37 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 9/4/2018 11:02 AM, Shahaf Shuler wrote:
>> Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit:
>>> Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx
>>>
>>> Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag.
>>> Without any specific Rx offload flag, default behavior by PMDs is to
>>> strip CRC.
>>>
>>> PMDs that support keeping CRC should advertise
>>> DEV_RX_OFFLOAD_KEEP_CRC
>>> Rx offload capability.
>>>
>>> Applications that require keeping CRC should check PMD capability first
>>> and if it is supported can enable this feature by setting
>>> DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure()
>>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> Acked-by: Tomasz Duszynski <tdu@semihalf.com>
>>> ---
>>> v2:
>>> * fix flag check
>>> * add KEEP_CRC flag into "show port cap #"
>>>
>>>   Note "show port cap #" and
>>>   "show port # [r/t]x_offload capabilities/configuration"
>>>   does same thing, in long term I suggest removing "show port cap" one
>>
>>
>> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
>>
>
> Applied to dpdk-next-net/master, thanks.

Should we have a little note about this api change in 18.11 release notes ?


-- 
David Marchand