From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH v3 1/2] eal: mmap uio resources using resourceX files Date: Tue, 24 Feb 2015 13:39:46 +0100 Message-ID: References: <1424703444-30761-1-git-send-email-bruce.richardson@intel.com> <1424780404-30824-1-git-send-email-bruce.richardson@intel.com> <1424780404-30824-2-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Bruce Richardson Return-path: In-Reply-To: <1424780404-30824-2-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Tue, Feb 24, 2015 at 1:20 PM, Bruce Richardson < bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote: > Instead of distinguishing the BAR mappings via offset within a single > file, originally /dev/uioX, switch to mapping each individual bar via > the appropriately numbered resourceX file. > > Signed-off-by: Bruce Richardson > --- > lib/librte_eal/common/include/rte_pci.h | 2 +- > lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 + > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 34 > ++++++++++++++++-------------- > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 1 + > 4 files changed, 21 insertions(+), 17 deletions(-) > As long as igb_uio / uio_pci_generic both work, this is fine for me. ack. -- David Marchand