From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH 0/2] Added functions to get RX/TX default configuration Date: Mon, 29 Sep 2014 16:40:34 +0200 Message-ID: References: <1411741159-6671-1-git-send-email-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "De Lara Guarch, Pablo" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hello Pablo, On Mon, Sep 29, 2014 at 4:02 PM, De Lara Guarch, Pablo < pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote: > Hi David, > > > - All I can see in this patchset is stuff that should remain in the PMD > (since > > this is really specific to them). > > > > - Anyway, if you want to let application get this information, why the > new API > > ? > > From my point of view, this should go in rte_eth_dev_info_get(). > > Thanks for the comments. Main changes are in the PMDs, and I only added > two functions in rte_ethdev.c, which basically calls the functions in the > PMDs. > Anyway, so you suggest to modify the rte_eth_dev_info structure, so it > also contains these two structures populated with the default values? > - Yep, that would be the idea. This way applications can reuse these structures "as is" or change some values before calling rx / tx _queue_setup. - By the way, I noticed that rte_eth_dev_info_get() is only resetting part of the dev_info structure given by the user. We might want to reset the dev_info structure to 0 before filling it ? >>From my point of view, rte_eth_dev_info_get() is not in the datapath. I would prefer it to be safe. -- David Marchand