From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand@6wind.com>
Subject: Re: [PATCH] eal: default to one memory channel if not
	specified
Date: Wed, 14 Oct 2015 13:45:09 +0200
Message-ID: <CALwxeUuz12PmccAvt=kWCKHYzoO4z5LLXCdZd=j4Pyu-4+Butg@mail.gmail.com>
References: <d209690bda34d966299f000d63c0451b969262b0.1444818124.git.pmatilai@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Panu Matilainen <pmatilai@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-oi0-f43.google.com (mail-oi0-f43.google.com
 [209.85.218.43]) by dpdk.org (Postfix) with ESMTP id 80A755697
 for <dev@dpdk.org>; Wed, 14 Oct 2015 13:45:10 +0200 (CEST)
Received: by oixx6 with SMTP id x6so10171253oix.2
 for <dev@dpdk.org>; Wed, 14 Oct 2015 04:45:10 -0700 (PDT)
In-Reply-To: <d209690bda34d966299f000d63c0451b969262b0.1444818124.git.pmatilai@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Panu,

On Wed, Oct 14, 2015 at 12:22 PM, Panu Matilainen <pmatilai@redhat.com>
wrote:

> Obtaining the correct value, especially from a running system, can
> be anything from difficult to plain impossible.  Since the value is
> merely an optimization and does not affect functionality otherwise,
> its pointless to force such a guess on users initially, such things
> belong to performance tuning phase.
>
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> ---
>  lib/librte_eal/common/eal_common_options.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_options.c
> b/lib/librte_eal/common/eal_common_options.c
> index 1f459ac..28f10a2 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -104,7 +104,7 @@ eal_reset_internal_config(struct internal_config
> *internal_cfg)
>
>         internal_cfg->memory = 0;
>         internal_cfg->force_nrank = 0;
> -       internal_cfg->force_nchannel = 0;
> +       internal_cfg->force_nchannel = 1;
>

Well, not too sure about this default value.

- mempool code is already checking for the 0 value.
- API already tells for rte_memory_get_nchannel() :
 *
@return

 *   The number of memory channels on the system. The value is 0 if
unknown
 *   or not the same on all
devices.

So, I would let it 0.


-- 
David Marchand