From: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Xie, Huawei" <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH RFC 0/3] only call iopl when necessary
Date: Wed, 27 Aug 2014 11:34:06 +0200 [thread overview]
Message-ID: <CALwxeUvLCsAcQuxyRz-cES5GSnS9ApBQNbh4c9OFvW=UQL3+hg@mail.gmail.com> (raw)
In-Reply-To: <C37D651A908B024F974696C65296B57B0F27CBA6-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Hello,
On Wed, Aug 27, 2014 at 11:22 AM, Xie, Huawei <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> Hi David:
> The reason iopl is put in rte_eal_init is that we want all later created
> DPDK processes/threads inherit the iopl permission.
> If you only call iopl in pmd_init, RX/TX and other threads which needs io
> permission will segmentation fault.
>
rte_virtio_pmd_init() is the constructor that registers the virtio pmd in
the driver list.
It is called from rte_eal_dev_init() in rte_eal_init().
So it means my patch only moved the call to iopl() a little later in
rte_eal_init() and this is still before any thread has been created.
I can't see why this would cause a problem.
--
David Marchand
next prev parent reply other threads:[~2014-08-27 9:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 14:11 [PATCH RFC 0/3] only call iopl when necessary David Marchand
[not found] ` <1409062300-17004-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-08-26 14:11 ` [PATCH RFC 1/3] eal/bsd: fix fd leak David Marchand
[not found] ` <1409062300-17004-2-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-25 10:17 ` Thomas Monjalon
2014-08-26 14:11 ` [PATCH RFC 2/3] eal: don't call rte_eal_iopl_init unconditionnally David Marchand
[not found] ` <1409062300-17004-3-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-08-27 17:26 ` Xie, Huawei
2014-08-26 14:11 ` [PATCH RFC 3/3] eal: remove unused flags field David Marchand
2014-08-27 9:22 ` [PATCH RFC 0/3] only call iopl when necessary Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F27CBA6-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-27 9:34 ` David Marchand [this message]
[not found] ` <CALwxeUvLCsAcQuxyRz-cES5GSnS9ApBQNbh4c9OFvW=UQL3+hg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-27 9:57 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F27CC9A-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-27 10:04 ` David Marchand
[not found] ` <CALwxeUvB0XKr7AUGHLDh6NgsEmGWkELOAX=NQMDk5FML7Ptbmg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-27 10:09 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F27CCED-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-27 10:24 ` Thomas Monjalon
2014-08-27 21:22 ` Patel, Rashmin N
[not found] ` <C68F1134885B32458704E1E4DA3E34F341A2D6DF-AtyAts71sc9qS6EAlXoojrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-27 22:12 ` Stephen Hemminger
2014-09-29 12:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUvLCsAcQuxyRz-cES5GSnS9ApBQNbh4c9OFvW=UQL3+hg@mail.gmail.com' \
--to=david.marchand-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).