From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 14/17] e1000: clean log messages
Date: Tue, 2 Sep 2014 21:19:37 +0200
Message-ID: <CALwxeUvLyFthbf8aaEpGkbCvhsWy+M7dfQr4+VusurBAOddBvA@mail.gmail.com>
References: <1409567080-27083-1-git-send-email-david.marchand@6wind.com>
 <1409567080-27083-15-git-send-email-david.marchand@6wind.com>
 <CADNuJVqhOy6AfYO5OuUn=kmQsBVkwrRunXKXKkQ88bexPtWgsg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Jay Rolette <rolette-bIuJOMs36aleGPcbtGPokg@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <CADNuJVqhOy6AfYO5OuUn=kmQsBVkwrRunXKXKkQ88bexPtWgsg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Tue, Sep 2, 2014 at 9:05 PM, Jay Rolette <rolette-bIuJOMs36aleGPcbtGPokg@public.gmane.org> wrote:

> Couple of minor nits noted. The bigger feedback would be that if you could
> keep the "whitespace / line-wrapping / formatting" only changes in separate
> patches, these reviews would be easier to get through.
>

Hum, indeed, I should have done this.
Will keep in mind.


        /* Free memory prior to re-allocation if needed */
>>         if (dev->data->tx_queues[queue_idx] != NULL) {
>> @@ -1271,7 +1271,7 @@ eth_igb_tx_queue_setup(struct rte_eth_dev *dev,
>>                 igb_tx_queue_release(txq);
>>                 return (-ENOMEM);
>>         }
>> -       PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p
>> dma_addr=0x%"PRIx64"\n",
>> +       PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p dma_addr=0x%"PRIx64"",
>>
> The empty string after PRIx64 is extraneous
>
>
>>                      txq->sw_ring, txq->tx_ring, txq->tx_ring_phys_addr);
>>
>>         igb_reset_tx_queue(txq, dev);
>> @@ -1409,7 +1409,7 @@ eth_igb_rx_queue_setup(struct rte_eth_dev *dev,
>>                 igb_rx_queue_release(rxq);
>>                 return (-ENOMEM);
>>         }
>> -       PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p
>> dma_addr=0x%"PRIx64"\n",
>> +       PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p dma_addr=0x%"PRIx64"",
>>
> The empty string after PRIx64 is extraneous
>
>

Ok, I will update.

Thanks.


-- 
David Marchand