From: David Marchand <david.marchand@6wind.com>
To: Igor Ryzhov <iryzhov@nfware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] pci: fix one device probing
Date: Mon, 7 Nov 2016 14:26:53 +0100 [thread overview]
Message-ID: <CALwxeUvPNv4HV+xNaRXkUeC3jidnzf6TYEVts6JHwT68W=82-A@mail.gmail.com> (raw)
In-Reply-To: <1470311406-38841-1-git-send-email-iryzhov@nfware.com>
On Thu, Aug 4, 2016 at 1:50 PM, Igor Ryzhov <iryzhov@nfware.com> wrote:
> The rte_eal_pci_probe_one function could return false positive result if
> no driver is found for the device.
>
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
> ---
> lib/librte_eal/common/eal_common_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
> index 7248c38..bfb6fd2 100644
> --- a/lib/librte_eal/common/eal_common_pci.c
> +++ b/lib/librte_eal/common/eal_common_pci.c
> @@ -344,7 +344,7 @@ rte_eal_pci_probe_one(const struct rte_pci_addr *addr)
> continue;
>
> ret = pci_probe_all_drivers(dev);
> - if (ret < 0)
> + if (ret)
> goto err_return;
> return 0;
> }
Acked-by: David Marchand <david.marchand@6wind.com>
--
David Marchand
next prev parent reply other threads:[~2016-11-07 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 11:50 [PATCH] pci: fix one device probing Igor Ryzhov
2016-09-16 13:20 ` Thomas Monjalon
2016-11-07 13:26 ` David Marchand [this message]
2016-11-07 13:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUvPNv4HV+xNaRXkUeC3jidnzf6TYEVts6JHwT68W=82-A@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=iryzhov@nfware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).