From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH v3 00/17] Support ARMv7 architecture Date: Wed, 28 Oct 2015 15:54:47 +0100 Message-ID: References: <1445877458-31052-1-git-send-email-viktorin@rehivetech.com> <1445973229-22058-1-git-send-email-viktorin@rehivetech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" To: Jan Viktorin Return-path: Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) by dpdk.org (Postfix) with ESMTP id 547C18DA8 for ; Wed, 28 Oct 2015 15:54:48 +0100 (CET) Received: by oies66 with SMTP id s66so5784893oie.1 for ; Wed, 28 Oct 2015 07:54:47 -0700 (PDT) In-Reply-To: <1445973229-22058-1-git-send-email-viktorin@rehivetech.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Jan, On Tue, Oct 27, 2015 at 8:13 PM, Jan Viktorin wrote: > Hello DPDK community, > > this is the third attempt to post support for ARMv7 into the DPDK. > There are changes related to the LPM and ACL libraries only: > > * included rte_vect.h, however, it is more a placeholder > * rte_lpm.h was simplified due to the previous point > * ACL now compiles as we detect whether the compiler > supports SSE 4.1 > This patchset looks good to me (with the minor comments I sent). And armv8 support should fit quite well in this. A last few things : - checkpatch is not happy with some patches, can you have a look at this ? - can you update the 2.2 release notes as part of this patchset to announce armv7 support ? - I am not really sure the acl et lpm fixes really belong to this patchset as a more larger cleanup is necessary to have all libraries compile fine on non-x86 - since you introduce a new architecture, do you intend to run daily build checks and send reports to the test-report mailing list ? Thanks. -- David Marchand