From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH 3/3] ethdev: prevent segfaults in rte_eth_dev_is_detachable Date: Tue, 3 Nov 2015 12:19:50 +0100 Message-ID: References: <1446108903-14412-1-git-send-email-david.marchand@6wind.com> <1446108903-14412-4-git-send-email-david.marchand@6wind.com> <1835472.4si0y6iqvT@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by dpdk.org (Postfix) with ESMTP id 16C348E86 for ; Tue, 3 Nov 2015 12:19:51 +0100 (CET) Received: by obbwb3 with SMTP id wb3so9701908obb.0 for ; Tue, 03 Nov 2015 03:19:50 -0800 (PST) In-Reply-To: <1835472.4si0y6iqvT@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 3, 2015 at 12:10 PM, Thomas Monjalon wrote: > 2015-10-29 09:55, David Marchand: > > From: Maxime Leroy > > > > Some drivers like virtual ones don't specify any driver pointer in the > > structure rte_eth_dev. > > > > To prevent segfault, we should check if this pointer is NULL before > > dereferencing it. > > > > Signed-off-by: Maxime Leroy > > Signed-off-by: David Marchand > > It is not clear what the problem is. > And the driver fields should probably be removed or changed as it too > tigthly > related to the PCI driver. > It does look odd to me as well, quickly went through head, and did not see a case where this could happen. Maxime is not available at the moment, so I think I will just drop this patch. How about this patchset rebased on head with just the first two patches ? -- David Marchand