From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH] stats: remove useless memset's Date: Wed, 21 Jan 2015 14:08:02 +0100 Message-ID: References: <1421813818-2354-1-git-send-email-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev-VfR2kkLFssw@public.gmane.org" , Stephen Hemminger To: Stephen Hemminger Return-path: In-Reply-To: <1421813818-2354-1-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hello Stephen, On Wed, Jan 21, 2015 at 5:16 AM, wrote: > From: Stephen Hemminger > > The rte_eth_stats_get is the only API that should call the device > statistics function directly, and it already does a memset of the > resulting structure. Therefore doing memset() in the driver is > redundant and should be removed. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_pmd_af_packet/rte_eth_af_packet.c | 2 -- > lib/librte_pmd_bond/rte_eth_bond_pmd.c | 4 ---- > lib/librte_pmd_enic/enic_main.c | 1 - > lib/librte_pmd_i40e/i40e_ethdev_vf.c | 1 - > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 1 - > lib/librte_pmd_ring/rte_eth_ring.c | 1 - > 6 files changed, 10 deletions(-) > I think you missed some : - lib/librte_pmd_e1000/igb_ethdev.c function eth_igbvf_stats_get() - lib/librte_pmd_pcap/rte_eth_pcap.c function eth_stats_get() With these fixed : Acked-By: David Marchand -- David Marchand