From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tonghao Zhang Subject: Re: [PATCH 1/5] net/ixgbevf: unregister irq handler when other interrupts not allowed. Date: Thu, 11 Jan 2018 22:24:29 +0800 Message-ID: References: <1515161439-4792-1-git-send-email-xiangxia.m.yue@gmail.com> <94479800C636CB44BD422CB454846E013208AC48@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: "dev@dpdk.org" To: "Xing, Beilei" Return-path: Received: from mail-ot0-f193.google.com (mail-ot0-f193.google.com [74.125.82.193]) by dpdk.org (Postfix) with ESMTP id F05A371B3 for ; Thu, 11 Jan 2018 15:24:30 +0100 (CET) Received: by mail-ot0-f193.google.com with SMTP id p16so2226515otf.1 for ; Thu, 11 Jan 2018 06:24:30 -0800 (PST) In-Reply-To: <94479800C636CB44BD422CB454846E013208AC48@SHSMSX101.ccr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 11, 2018 at 2:55 PM, Xing, Beilei wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tonghao Zhang >> Sent: Friday, January 5, 2018 10:11 PM >> To: dev@dpdk.org >> Cc: Tonghao Zhang >> Subject: [dpdk-dev] [PATCH 1/5] net/ixgbevf: unregister irq handler when >> other interrupts not allowed. >> >> When we bind the ixgbe VF (e.g 82599 card) to igb_uio and enable the rx- >> interrupt, there will be more than one epoll_wait on intr_handle.fd. >> One is in "eal-intr-thread" thread, and the others are in the thread which call >> the "rte_epoll_wait". The problem is that sometiems "eal-intr-thread" >> thread will process the rx interrupt, and then rte_epoll_wait can't get the >> event any more, and the packets may be lost. >> >> We should unregister the status interrupt handler in "eal-intr-thread" >> thread and the ixgbe pf is in the same case. >> >> Signed-off-by: Tonghao Zhang > > The patch looks OK for me, the commit log can be reworded, for example, "we" can be removed. Yes > Apart from that: > Acked-by: Beilei Xing Thanks for your reviews. I will repost v2 > >> --- >> drivers/net/ixgbe/ixgbe_ethdev.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >> b/drivers/net/ixgbe/ixgbe_ethdev.c >> index 43e0132..e67389f 100644 >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >> @@ -5049,6 +5049,15 @@ static int >> ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, >> } >> ixgbevf_configure_msix(dev); >> >> + if (!rte_intr_allow_others(intr_handle)) { >> + rte_intr_callback_unregister(intr_handle, >> + ixgbevf_dev_interrupt_handler, >> + dev); >> + if (dev->data->dev_conf.intr_conf.lsc != 0) >> + PMD_INIT_LOG(INFO, "lsc won't enable because of" >> + " no intr multiplex"); >> + } >> + >> /* When a VF port is bound to VFIO-PCI, only miscellaneous interrupt >> * is mapped to VFIO vector 0 in eth_ixgbevf_dev_init( ). >> * If previous VFIO interrupt mapping setting in >> eth_ixgbevf_dev_init( ) @@ -5091,6 +5100,12 @@ static int >> ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, >> >> ixgbe_dev_clear_queues(dev); >> >> + if (!rte_intr_allow_others(intr_handle)) >> + /* resume to the default handler */ >> + rte_intr_callback_register(intr_handle, >> + ixgbevf_dev_interrupt_handler, >> + (void *)dev); >> + >> /* Clean datapath event and queue/vec mapping */ >> rte_intr_efd_disable(intr_handle); >> if (intr_handle->intr_vec != NULL) { >> -- >> 1.8.3.1 >