From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIEtvemlr?= Subject: Re: [PATCH 2/4] bus/pci: reference driver structure Date: Thu, 28 Jun 2018 15:05:08 +0200 Message-ID: References: <1523455637-31719-1-git-send-email-rk@semihalf.com> <1523455637-31719-3-git-send-email-rk@semihalf.com> <3c81fa25-5508-5111-0c24-b022665b507a@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: dev@dpdk.org, Marcin Wojtas , =?UTF-8?Q?Micha=C5=82_Krawczyk?= , "Tzalik, Guy" , "Schmeilin, Evgeny" , "Matushevsky, Alexander" , "Chauskin, Igor" To: Ferruh Yigit Return-path: Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 1C2A85F45 for ; Thu, 28 Jun 2018 15:05:09 +0200 (CEST) Received: by mail-lj1-f196.google.com with SMTP id u6-v6so4436315lju.13 for ; Thu, 28 Jun 2018 06:05:09 -0700 (PDT) In-Reply-To: <3c81fa25-5508-5111-0c24-b022665b507a@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2018-06-27 18:36 GMT+02:00 Ferruh Yigit : > On 4/11/2018 3:07 PM, Rafal Kozik wrote: >> Reference driver structure before calling rte_pci_map_device. >> It allow to use driver flags for adjusting configuration. >> >> Signed-off-by: Rafal Kozik >> --- >> drivers/bus/pci/pci_common.c | 13 ++++++++----- >> 1 file changed, 8 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c >> index 2a00f36..15e9a47 100644 >> --- a/drivers/bus/pci/pci_common.c >> +++ b/drivers/bus/pci/pci_common.c >> @@ -159,17 +159,20 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, >> RTE_LOG(INFO, EAL, " probe driver: %x:%x %s\n", dev->id.vendor_id, >> dev->id.device_id, dr->driver.name); >> >> + /* reference driver structure */ >> + dev->driver = dr; >> + dev->device.driver = &dr->driver; > > It can be good to comment that this needs to be before rte_pci_map_device() > incase someone wants to refactor code later. > I will fix it in new, rebased patch set. >> + >> if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) { >> /* map resources for devices that use igb_uio */ >> ret = rte_pci_map_device(dev); >> - if (ret != 0) >> + if (ret != 0) { >> + dev->driver = NULL; >> + dev->device.driver = NULL; >> return ret; >> + } >> } >> >> - /* reference driver structure */ >> - dev->driver = dr; >> - dev->device.driver = &dr->driver; >> - >> /* call the driver probe() function */ >> ret = dr->probe(dr, dev); >> if (ret) { >> >