From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIEtvemlr?= Subject: Re: [PATCH] doc: update for ENA supported drivers Date: Wed, 10 Oct 2018 14:04:17 +0200 Message-ID: References: <1538730173-7444-1-git-send-email-rk@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, Marcin Wojtas , =?UTF-8?Q?Micha=C5=82_Krawczyk?= , "Tzalik, Guy" , "Schmeilin, Evgeny" , "Matushevsky, Alexander" , "Chauskin, Igor" , john.mcnamara@intel.com, marko.kovacevic@intel.com, "Machulsky, Zorik" , stable@dpdk.org To: Ferruh Yigit Return-path: Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by dpdk.org (Postfix) with ESMTP id C1B1A1B42D for ; Wed, 10 Oct 2018 14:04:29 +0200 (CEST) Received: by mail-lf1-f65.google.com with SMTP id m18-v6so3761130lfl.11 for ; Wed, 10 Oct 2018 05:04:29 -0700 (PDT) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Ferruh, > Unless installed "igb_uio" won't be available to use with "modprobe", not= sure > about adding that detail, what do you think? I did not add it. In current version this information is already present: > -#. Bind the intended ENA device to igb_uio module > This is only required if there is no iommu on the system, right? Won't en= a will > work without this parameter on the system that has iommu? I will prepare next version, that will clarify it. Best regards, Rafal wt., 9 pa=C5=BA 2018 o 12:56 Ferruh Yigit napisa= =C5=82(a): > > On 10/5/2018 10:02 AM, Rafal Kozik wrote: > > Add instruction how to bind ENA to VFIO-PCI driver. > > > > Fixes: cf8a122c296a ("ena: introduce documentation") > > Cc: stable@dpdk.org > > > > Signed-off-by: Zorik Machulsky > > Signed-off-by: Rafal Kozik > > Acked-by: Michal Krawczyk > > --- > > doc/guides/nics/ena.rst | 12 +++++++++--- > > doc/guides/nics/features/ena.ini | 1 + > > 2 files changed, 10 insertions(+), 3 deletions(-) > > > > diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst > > index d19912e..0dfefc6 100644 > > --- a/doc/guides/nics/ena.rst > > +++ b/doc/guides/nics/ena.rst > > @@ -187,11 +187,17 @@ Prerequisites > > ------------- > > > > #. Prepare the system as recommended by DPDK suite. This includes env= ironment > > - variables, hugepages configuration, tool-chains and configuration > > + variables, hugepages configuration, tool-chains and configuration. > > > > -#. Insert igb_uio kernel module using the command 'modprobe igb_uio' > > +#. ENA PMD can operate with vfio-pci or igb_uio driver. > > > > -#. Bind the intended ENA device to igb_uio module > > +#. Insert vfio-pci or igb_uio kernel module using the command > > + 'modprobe vfio-pci' or 'modprobe igb_uio' respectively. > > Unless installed "igb_uio" won't be available to use with "modprobe", not= sure > about adding that detail, what do you think? > > > + > > +#. If vfio-pci driver is used please make sure noiommu mode is enabled= : > > + echo 1 > /sys/module/vfio/parameters/enable_unsafe_noiommu_mode > > This is only required if there is no iommu on the system, right? Won't en= a will > work without this parameter on the system that has iommu? > > > + > > +#. Bind the intended ENA device to vfio-pci or igb_uio module. > > > > > > At this point the system should be ready to run DPDK applications. Onc= e the > > diff --git a/doc/guides/nics/features/ena.ini b/doc/guides/nics/feature= s/ena.ini > > index 691c1e3..aa6f05a 100644 > > --- a/doc/guides/nics/features/ena.ini > > +++ b/doc/guides/nics/features/ena.ini > > @@ -23,5 +23,6 @@ Inner L4 checksum =3D Y > > Basic stats =3D Y > > Extended stats =3D Y > > Linux UIO =3D Y > > +Linux VFIO =3D Y > > x86-32 =3D Y > > x86-64 =3D Y > > >