From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?UmFmYcWCIEtvemlr?= <rk@semihalf.com>
Subject: Re: [dpdk-stable] [PATCH v3] net/ena: fix out of order
	completion
Date: Wed, 21 Nov 2018 17:14:34 +0100
Message-ID: <CAMG3L49ZHzM_+MTL6W750fn91F9bE0rrGDZqRHPSPfD158vHgQ@mail.gmail.com>
References: <1542731185-10136-1-git-send-email-rk@semihalf.com>
 <1542788474-32677-1-git-send-email-rk@semihalf.com>
 <fbb37c0e-1985-44c7-5dde-3300f527b913@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Marcin Wojtas <mw@semihalf.com>,
 =?UTF-8?Q?Micha=C5=82_Krawczyk?= <mk@semihalf.com>,
 "Tzalik, Guy" <gtzalik@amazon.com>, "Schmeilin, Evgeny" <evgenys@amazon.com>,
 "Matushevsky, Alexander" <matua@amazon.com>, "Chauskin,
 Igor" <igorch@amazon.com>, stable@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com
 [209.85.208.176]) by dpdk.org (Postfix) with ESMTP id 8C5452C01
 for <dev@dpdk.org>; Wed, 21 Nov 2018 17:14:47 +0100 (CET)
Received: by mail-lj1-f176.google.com with SMTP id x85-v6so5355650ljb.2
 for <dev@dpdk.org>; Wed, 21 Nov 2018 08:14:47 -0800 (PST)
In-Reply-To: <fbb37c0e-1985-44c7-5dde-3300f527b913@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Ferruh,

this patch fix issue in Rx path which could have caused receive of
wrong packets.
If it is possible, I would be very grateful if this patch could be
applied to v18.11.

Best regards,
Rafal

=C5=9Br., 21 lis 2018 o 16:16 Ferruh Yigit <ferruh.yigit@intel.com> napisa=
=C5=82(a):
>
> On 11/21/2018 8:21 AM, Rafal Kozik wrote:
> > rx_buffer_info should be refill not linearly, but out of order.
> > IDs should be taken from empty_rx_reqs array.
> >
> > rx_refill_buffer is introduced to temporary storage
> > bulk of mbufs taken from pool.
> >
> > In case of error unused mbufs are put back to pool.
> >
> > Fixes: c2034976673d ("net/ena: add Rx out of order completion")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rafal Kozik <rk@semihalf.com>
> > Acked-by: Michal Krawczyk <mk@semihalf.com>
>
> Hi Rafal,
>
> This patch sent after rc4, I suggest pushing this out to next release, an=
y
> objection? Is this really a critical patch to get in at this stage?