From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Jan_M=C4=99dala?= <jan@semihalf.com>
Subject: Re: [PATCH v4 20/29] net/ena: use eal I/O device memory
 read/write API
Date: Tue, 17 Jan 2017 13:51:38 +0100
Message-ID: <CANw_3ZfwS1dMer3PcCnV3bnZbjww0w2eiAu1NithQ283WJPxPA@mail.gmail.com>
References: <1484212646-10338-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1484637244-7548-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1484637244-7548-21-git-send-email-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 jianbo.liu@linaro.org, viktorin@rehivetech.com,
 Jakub Palider <jpa@semihalf.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Santosh Shukla <santosh.shukla@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qt0-f169.google.com (mail-qt0-f169.google.com
 [209.85.216.169]) by dpdk.org (Postfix) with ESMTP id 3BBD42B83
 for <dev@dpdk.org>; Tue, 17 Jan 2017 13:51:39 +0100 (CET)
Received: by mail-qt0-f169.google.com with SMTP id k15so155192680qtg.3
 for <dev@dpdk.org>; Tue, 17 Jan 2017 04:51:38 -0800 (PST)
In-Reply-To: <1484637244-7548-21-git-send-email-jerin.jacob@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Jerin, Santosh,

As you are introducing improved I/O access API, I would like to ask to
change ENA platform code to:

* #define ENA_REG_WRITE32(value, reg) rte_write32_relaxed((value), (reg))*
* #define ENA_REG_READ32(reg) rte_read32_relaxed((reg))*

There is no more need to have read/write functions within platform code (
*readl()*, *writel()*, *writel_relaxed()*), as we can directly map our API
macro to DPDK platform implementation.
Also I would prefer to keep API within *drivers/net/ena/base/ena_eth_com.h*
and map define ENA_REG_WRITE32 to relaxed version (when barrier is needed
we call it explicitly in driver code, there is no need to have
ENA_REG_WRITE32_RELAXED). That will help us to manage code together between
the different platforms.

Should I do the change for ENA or do you want to keep the current flow and
take care of it?

=E2=80=8BBest regards
Jan