From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Subject: Re: Where is the padding code in DPDK? Date: Wed, 14 Nov 2018 13:45:19 +0800 Message-ID: References: <9f22d7f1-080e-1663-df8d-a3893248a93d@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: "Burakov, Anatoly" Return-path: Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by dpdk.org (Postfix) with ESMTP id C17AE493D for ; Wed, 14 Nov 2018 06:45:31 +0100 (CET) Received: by mail-qk1-f194.google.com with SMTP id 131so23812408qkd.4 for ; Tue, 13 Nov 2018 21:45:31 -0800 (PST) In-Reply-To: <9f22d7f1-080e-1663-df8d-a3893248a93d@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" OK, then shortly speaking, DPDK will NOT care about padding. NIC will care about padding while send and recv with NIC. kernel will care about while send and recv with vhostuser port. Is that right? Burakov, Anatoly =E4=BA=8E2018=E5=B9=B411=E6=9C= =8813=E6=97=A5=E5=91=A8=E4=BA=8C =E4=B8=8B=E5=8D=885:29=E5=86=99=E9=81=93= =EF=BC=9A > On 13-Nov-18 7:16 AM, Sam wrote: > > Hi all, > > > > As we know, ethernet frame must longer then 64B. > > > > So if I create rte_mbuf and fill it with just 60B data, will > > rte_eth_tx_burst add padding data, let the frame longer then 64B > > > > If it does, where is the code? > > > > Others can correct me if i'm wrong here, but specifically in case of > 64-byte packets, these are the shortest valid packets that you can send, > and a 64-byte packet will actually carry only 60 bytes' worth of packet > data, because there's a 4-byte CRC frame at the end (see Ethernet frame > format). If you enabled CRC offload, then your NIC will append the 4 > bytes at transmit. If you haven't, then it's up to each individual > driver/NIC to accept/reject such a packet because it can rightly be > considered malformed. > > In addition, your NIC may add e.g. VLAN tags or other stuff, again > depending on hardware offloads that you have enabled in your TX > configuration, which may push the packet size beyond 64 bytes while > having only 60 bytes of actual packet data. > > -- > Thanks, > Anatoly >