From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vladislav Zolotarov <vladz-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
Subject: Re: [PATCH v5 1/3] ixgbe: Cleanups
Date: Mon, 9 Mar 2015 20:21:54 +0200
Message-ID: <CAOYyTHbwch55eGwccw+D-+aEMoSOqs_umu2fqLf=kygv6GLbkA@mail.gmail.com>
References: <1425896433-12452-1-git-send-email-vladz@cloudius-systems.com>
 <1425896433-12452-2-git-send-email-vladz@cloudius-systems.com>
 <2601191342CEEE43887BDE71AB977258213F4B37@irsmsx105.ger.corp.intel.com>
 <54FD7F5A.4090809@intel.com>
 <2601191342CEEE43887BDE71AB977258213F4B99@irsmsx105.ger.corp.intel.com>
 <54FDC306.4030503@cloudius-systems.com>
 <2601191342CEEE43887BDE71AB977258213F4E68@irsmsx105.ger.corp.intel.com>
 <CAOYyTHZ6j83syfHpGY2ig+wU3azGAMjhRpT0w9oVpuJ1Nf_MGQ@mail.gmail.com>
 <B27915DBBA3421428155699D51E4CFE2ECC700@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: dev-VfR2kkLFssw@public.gmane.org
To: John Mcnamara <john.mcnamara-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2ECC700-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Mar 9, 2015 8:01 PM, "Mcnamara, John" <john.mcnamara-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Vladislav Zolotarov
> > Sent: Monday, March 9, 2015 5:14 PM
> > To: Ananyev, Konstantin
> > Cc: dev-VfR2kkLFssw@public.gmane.org
> > Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups
> >
> > On Mar 9, 2015 6:39 PM, "Ananyev, Konstantin"
> > <konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > wrote:
> > > > > If I remember things correctly, it considered result at right side
> > > > > of
> > '=' operator as unsigned int,
> > > > > and then complained that we assign it to smaller size (unsigned
> > short) operand.
> > > >
> > > > If that's the case - that's a clear compiler bug.
> > >
> > > Might be, though if we still have to support it, there is no much
> > > choice
> > I am afraid.
> >
> > Well to begin with could anybody who has this icc thing (preferably the
> > latest version) post the compilation errors u are talking about
>
> Hi,
>
> For what it is worth there aren't any warnings with ICC 13 and the 1/3
patch (+ the previous patchset):
>
>   $ make T=x86_64-native-linuxapp-icc install CC=icc
>   Build complete
>
>   $ git log --pretty=format:"%h - %an: %s" -4
>   b5d06e4 - Vladislav Zolotarov: ixgbe: Cleanups
>   3cd0367 - Vladislav Zolotarov: ixgbe: Unify the rx_pkt_bulk callback ...
>   10ed30e - Vladislav Zolotarov: ixgbe: Bug fix: Properly configure Rx ...
>   2a5bc6a - Vladislav Zolotarov: ixgbe: Use the rte_le_to_cpu_xx()/rte_...
>
>   $ icc --version
>   icc (ICC) 13.1.1 20130313

Thanks a lot, John.

>
> John.
> --
>
>